From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Jan Dittmer <jdittmer@ppp0.net>
Cc: linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>,
Hotplug List <pcihpd-discuss@lists.sourceforge.net>
Subject: Re: Is there a user space pci rescan method?
Date: Fri, 24 Sep 2004 14:12:44 +0200 [thread overview]
Message-ID: <200409241412.45204@bilbo.math.uni-mannheim.de> (raw)
In-Reply-To: <4154083B.6040109@ppp0.net>
Am Freitag, 24. September 2004 13:42 schrieben Sie:
> Rolf Eike Beer wrote:
> > Ok, here we go. This is my current diff that I use for my tests at home.
> > It adds dummyphp and cleans up fakephp a lot (read: kills it). Changes
> > from last version:
> >
> > -removed some dead comments
> > -removed some unused instructions
> > -reordered allocation in add_slot to do less memory allocations if there
> > is no device in slot
> > -changed param "usedonly" to "showunused" so it behaves like fakephp at
> > the first look: if you load dummyphp without parameters there are only
> > slots with devices in it.
> > -removed "DUMMY-" prefix to entries in /sys/bus/pci/slots/
> >
> > Please send comments so I can send it for inclusion soon.
>
> Well, first of all I think you should just submit a patch to add dummyphp
> and not removing fakephp in the same step. Also you somehow mis-copied the
I said it's my test diff and that I'll redo it for submission ;)
> patch to your mail app - most (not all) tabs are converted to one space (or
> is it just thunderbird displaying the mail?). Can you resend it? Then I'll
Yes, looks like KMail has eaten it. Hey KDE guys, is this intentional or was
this my fault?
You can get it from http://opensource.sf-tec.de/kernel/fake_vs_dummy.diff
> give it a try. Greg wrote in another mail that the 'proper' way of
> 'powering up' device slots should be to rescan the entire bus. I don't
> know, your approach certainly seems easier, but you are bound to either
> display all pci slots which may come to live or just the ones in the system
> already, which means you cannot rescan slots which weren't equipped on boot
> up. So perhaps adding a rescan method to fakephp is indeed cleaner.
This is for simulating hotplug events. I don't know how there could be a slot
where you put in a device that has not been there on system bootup. Ok, you
can trigger such a case by disabling a slot, rmmod dummyphp, modprobe
dummyphp again. Greg didn't like dummyphp to display all logical slots even
if there is no device in them - which I can understand, under normal
circumstances you will never have a use for this extra slots. If you want
them just do "modprobe dummyphp showunused=1" and you'll get them all.
Normally you will just remove and bring back one or two cards in the system
(e.g. your NIC or sound card, depending on xmms or irc being on top of your
priority list *g*). So from my point of view it's a good idea to keep the
slot dirs on remove so you can just go back in your command history and
replace 0 with 1 to get the device back. I don't see why bus structure or
whatever may ever change so rescanning the whole bus is IMHO a bit overkill.
Adding a rescan file is also extra work, the power file is there
automagically ;)
Eike
next prev parent reply other threads:[~2004-09-24 12:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-22 22:00 Is there a user space pci rescan method? Dave Aubin
2004-09-22 23:58 ` Jan Dittmer
2004-09-23 0:26 ` Greg KH
2004-09-23 15:04 ` Jan Dittmer
2004-09-23 16:49 ` Rolf Eike Beer
2004-09-23 16:53 ` Jan Dittmer
2004-09-23 17:05 ` Rolf Eike Beer
2004-09-24 10:41 ` Rolf Eike Beer
2004-09-24 11:42 ` Jan Dittmer
2004-09-24 12:12 ` Rolf Eike Beer [this message]
2004-09-24 12:16 ` Jan Dittmer
2004-09-24 12:32 ` Rolf Eike Beer
2004-09-24 14:55 ` Greg KH
2004-09-27 9:14 ` Rolf Eike Beer
2004-10-10 0:13 ` Jan Dittmer
2004-10-10 0:59 ` Jan Dittmer
2004-10-10 13:45 ` Jan Dittmer
2004-10-30 4:16 ` Greg KH
2004-10-31 23:59 ` [patch 1/2] fakephp: introduce pci_bus_add_device Jan Dittmer
2004-11-01 9:35 ` Christoph Hellwig
2004-11-02 22:51 ` Jan Dittmer
2004-11-11 23:47 ` Greg KH
2004-11-12 0:13 ` Jan Dittmer
2004-11-12 18:59 ` Greg KH
2004-10-31 23:59 ` [patch 2/2] fakephp: add pci bus rescan ability Jan Dittmer
2004-11-12 18:59 ` Greg KH
2004-09-24 13:09 ` [Pcihpd-discuss] Re: Is there a user space pci rescan method? Matthew Wilcox
2004-09-24 13:18 ` Rolf Eike Beer
2004-09-24 12:40 ` Jan Dittmer
2004-09-24 12:59 ` Rolf Eike Beer
2004-09-23 23:31 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2004-09-22 21:58 Dave Aubin
2004-09-22 20:30 Dave Aubin
2004-09-22 20:04 ` Alan Cox
2004-09-22 20:42 ` Richard B. Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200409241412.45204@bilbo.math.uni-mannheim.de \
--to=eike-kernel@sf-tec.de \
--cc=greg@kroah.com \
--cc=jdittmer@ppp0.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pcihpd-discuss@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.