From: Nishanth Aravamudan <nacc@us.ibm.com>
To: janitor@sternwelten.at
Cc: akpm@digeo.com, linux-kernel@vger.kernel.org
Subject: Re: [patch 02/26] char/cyclades: replace schedule_timeout() with msleep_interruptible()
Date: Fri, 24 Sep 2004 08:55:34 -0700 [thread overview]
Message-ID: <20040924155534.GA1757@us.ibm.com> (raw)
In-Reply-To: <E1CAa9D-0007mL-31@sputnik>
On Thu, Sep 23, 2004 at 10:24:58PM +0200, janitor@sternwelten.at wrote:
>
>
>
> Any comments would be appreciated.
>
> Description: Use msleep_interruptible() instead of schedule_timeout()
> to guarantee the task delays as expected.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
>
> Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
> ---
>
> linux-2.6.9-rc2-bk7-max/drivers/char/cyclades.c | 9 +++------
> 1 files changed, 3 insertions(+), 6 deletions(-)
>
> diff -puN drivers/char/cyclades.c~msleep_interruptible-drivers_char_cyclades drivers/char/cyclades.c
> --- linux-2.6.9-rc2-bk7/drivers/char/cyclades.c~msleep_interruptible-drivers_char_cyclades 2004-09-21 21:07:58.000000000 +0200
> +++ linux-2.6.9-rc2-bk7-max/drivers/char/cyclades.c 2004-09-21 21:07:58.000000000 +0200
> @@ -2717,8 +2717,7 @@ cy_wait_until_sent(struct tty_struct *tt
> #ifdef CY_DEBUG_WAIT_UNTIL_SENT
> printk("Not clean (jiff=%lu)...", jiffies);
> #endif
> - current->state = TASK_INTERRUPTIBLE;
> - schedule_timeout(char_time);
> + msleep_interruptible(msecs_to_jiffies(char_time));
Looks like the wrong macro was used here (should be jiffies_to_msecs()).
Max, want me to send it to you again?
-Nish
prev parent reply other threads:[~2004-09-24 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-23 20:24 [patch 02/26] char/cyclades: replace schedule_timeout() with msleep_interruptible() janitor
2004-09-24 15:55 ` Nishanth Aravamudan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040924155534.GA1757@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=akpm@digeo.com \
--cc=janitor@sternwelten.at \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.