All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH 2.6.9-rc2 28/38] net/pcnet32: replace
Date: Fri, 24 Sep 2004 18:44:44 +0000	[thread overview]
Message-ID: <20040924184444.GF16153@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040924180825.GH1757@us.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

On Fri, Sep 24, 2004 at 11:40:42AM -0700, Nishanth Aravamudan wrote:
> > >      if ((!data) || (data > (u32)(MAX_SCHEDULE_TIMEOUT / HZ)))
> > >      data = (u32)(MAX_SCHEDULE_TIMEOUT / HZ);
> > 	if ((!data) || (data > (u32)(MAX_SCHEDULE_TIMEOUT / 1000))
> > 		data = (u32)(MAX_SCHEDULE_TIMEOUT / 1000)
> I agree - the tabbing in that whole driver is non-standard (looks to be
> 4 spaces). And some places simply aren't tabbed like this one.

It wasn't the tabbing, but the divisor that I was complaining about.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2004-09-24 18:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-24 18:08 [Kernel-janitors] [PATCH 2.6.9-rc2 28/38] net/pcnet32: replace Nishanth Aravamudan
2004-09-24 18:21 ` Matthew Wilcox
2004-09-24 18:33 ` Matthew Wilcox
2004-09-24 18:40 ` Nishanth Aravamudan
2004-09-24 18:44 ` Matthew Wilcox [this message]
2004-09-24 18:46 ` Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040924184444.GF16153@parcelfarce.linux.theplanet.co.uk \
    --to=matthew@wil.cx \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.