All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Oester <kernel@linuxace.com>
To: netfilter-devel@lists.netfilter.org
Subject: [PATCH] time match does not track DST changes
Date: Fri, 24 Sep 2004 16:11:26 -0700	[thread overview]
Message-ID: <20040924231126.GA9030@linuxace.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

The time match does not follow daylight savings time changes.
Without adding timezone information to the kernel, fixing the
module doesn't seem possible.  

I considered adding a /proc entry to configure whether to add
an hour or not, but doing so would still require user intervention,
and the user can just as easily fix things up with this:

   hwclock --systohc ; hwclock --hctosys

So, the below just adds a couple notes so users are aware of 
this limitation.

Unless someone thinks of a better idea, this closes bugzilla #75.


Phil

[-- Attachment #2: patch-time --]
[-- Type: text/plain, Size: 1217 bytes --]

diff -ru ipt-orig/extensions/libipt_time.c ipt-new/extensions/libipt_time.c
--- ipt-orig/extensions/libipt_time.c	2004-05-16 01:48:04.000000000 -0700
+++ ipt-new/extensions/libipt_time.c	2004-09-24 16:03:30.289605227 -0700
@@ -21,6 +21,7 @@
 " [ --timestart value ] [ --timestop value] [ --days listofdays ] [ --datestart value ] [ --datestop value ]\n"
 "          timestart value : HH:MM (default 00:00)\n"
 "          timestop  value : HH:MM (default 23:59)\n"
+"                            Note: daylight savings time changes are not tracked\n"
 "          listofdays value: a list of days to apply\n"
 "                            from Mon,Tue,Wed,Thu,Fri,Sat,Sun\n"
 "                            Coma speparated, no space, case sensitive.\n"
diff -ru pom-orig/time/help pom-new/time/help
--- pom-orig/time/help	2004-05-05 03:11:24.000000000 -0700
+++ pom-new/time/help	2004-09-24 16:01:05.830178992 -0700
@@ -30,3 +30,5 @@
   -A OUTPUT -m time --timestart 8:00 --timestop 18:00 --Days Mon --date-stop 2010
   will match the packets (locally generated) that have a departure timestamp
   in the range 8:00->18:00 on Monday only, until 2010
+
+NOTE: the time match does not track changes in daylight savings time

             reply	other threads:[~2004-09-24 23:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-24 23:11 Phil Oester [this message]
2004-09-26  7:43 ` [PATCH] time match does not track DST changes Harald Welte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040924231126.GA9030@linuxace.com \
    --to=kernel@linuxace.com \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.