All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Lohoff <flo@rfc822.org>
To: linux-scsi@vger.kernel.org
Subject: spinlock sgiwd33 vs spinlock in wd33c93
Date: Sat, 25 Sep 2004 14:37:33 +0200	[thread overview]
Message-ID: <20040925123733.GC2630@paradigm.rfc822.org> (raw)


Hi,
by staring at the code i had the suspicion that the spinlock in the
users of the generic wd33c93.c might be obsolete or is my brain too
twisted.

     93
     94   spin_lock_irqsave(host->host_lock, flags);
     95   wd33c93_intr(host);
     96   spin_unlock_irqrestore(host->host_lock, flags);
     97

Whereas the wd33c93_intr itself does:

    775         asr = read_aux_stat(regs);
    776         if (!(asr & ASR_INT) || (asr & ASR_BSY))
    777                 return;
    778
    779         spin_lock_irqsave(&hostdata->lock, flags);
    780

It seems all users (gvp, a2091, a3000, sgiwd) do have it except mvme147

Flo
-- 
Florian Lohoff                  flo@rfc822.org             +49-171-2280134
                        Heisenberg may have been here.

                 reply	other threads:[~2004-09-25 12:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040925123733.GC2630@paradigm.rfc822.org \
    --to=flo@rfc822.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.