From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] [PATCH 2.6.9-rc2 2/4] sbus/bbc_envctrl: replace
Date: Mon, 27 Sep 2004 17:25:50 +0000 [thread overview]
Message-ID: <20040927172550.GL1676@us.ibm.com> (raw)
In-Reply-To: <20040920221309.GA2270@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
Any comments would be appreciated.
Description: Use msleep_interruptible() instead of
schedule_timeout() to guarantee the task delays as expected. Change the
units of POLL_INTERVAL to msecs to correspond to the msleep*() change.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.9-rc1-mm4-vanilla/drivers/sbus/char/bbc_envctrl.c 2004-09-09 23:05:59.000000000 -0700
+++ 2.6.9-rc1-mm4/drivers/sbus/char/bbc_envctrl.c 2004-09-10 15:41:09.000000000 -0700
@@ -452,7 +452,7 @@ static void fans_full_blast(void)
}
}
-#define POLL_INTERVAL (5 * HZ)
+#define POLL_INTERVAL (5 * 1000)
static unsigned long last_warning_jiffies;
static struct task_struct *kenvctrld_task;
@@ -468,8 +468,7 @@ static int kenvctrld(void *__unused)
struct bbc_cpu_temperature *tp;
struct bbc_fan_control *fp;
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(POLL_INTERVAL);
+ msleep_interruptible(POLL_INTERVAL);
if (signal_pending(current))
break;
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-09-27 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-20 22:13 [Kernel-janitors] [PATCH 2.6.9-rc2 2/4] message/exec-osm: replace Nishanth Aravamudan
2004-09-20 23:58 ` [Kernel-janitors] [PATCH 2.6.9-rc2 2/4] mtd/cfi_cmdset_0001: Nishanth Aravamudan
2004-09-24 23:18 ` [Kernel-janitors] [PATCH 2.6.9-rc2 2/4] pci hotplug/cpqphp: replace Nishanth Aravamudan
2004-09-27 17:25 ` Nishanth Aravamudan [this message]
2004-09-27 23:19 ` [Kernel-janitors] [PATCH 2.6.9-rc2 2/4] w1/w1_family: add Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040927172550.GL1676@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.