From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Aravamudan Date: Mon, 27 Sep 2004 21:46:38 +0000 Subject: [Kernel-janitors] [PATCH 2.6.9-rc2 2/9] usb/auerswald: reorder Message-Id: <20040927214638.GK1617@us.ibm.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="===============99206104442662246==" List-Id: References: <20040927214339.GI1617@us.ibm.com> In-Reply-To: <20040927214339.GI1617@us.ibm.com> To: kernel-janitors@vger.kernel.org --===============99206104442662246== Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Wrong subject line! Please use this version. -Nish Description: Reorder set_current_state() and schedule_timeout() so that schedule_timeout() will delay as expected every iteration of the while-loop. Without the addition, schedule_timeout() will return immediately in the first iteration. --- 2.6.9-rc2-vanilla/drivers/usb/misc/auerswald.c 2004-09-13 17:15:54.000000000 -0700 +++ 2.6.9-rc2/drivers/usb/misc/auerswald.c 2004-09-27 14:42:24.000000000 -0700 @@ -626,8 +626,8 @@ static int auerchain_start_wait_urb (pau while (timeout && !chs.done) { - timeout = schedule_timeout (timeout); set_current_state(TASK_UNINTERRUPTIBLE); + timeout = schedule_timeout (timeout); rmb(); } --===============99206104442662246== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org http://lists.osdl.org/mailman/listinfo/kernel-janitors --===============99206104442662246==--