From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] [PATCH 2.6.9-rc2 4/4] w1/w1: add
Date: Mon, 27 Sep 2004 23:20:29 +0000 [thread overview]
Message-ID: <20040927232029.GA1617@us.ibm.com> (raw)
In-Reply-To: <20040920235909.GG2270@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
Any comments would be appreciated.
Description: Inserted set_current_state() before schedule_timeout() so
the task delays as expected. Without the insertion, schedule_timeout()
will return immediately.
--- 2.6.9-rc2-vanilla/drivers/w1/w1.c 2004-09-13 17:16:07.000000000 -0700
+++ 2.6.9-rc2/drivers/w1/w1.c 2004-09-14 10:45:44.000000000 -0700
@@ -446,8 +446,10 @@ static void w1_slave_detach(struct w1_sl
dev_info(&sl->dev, "%s: detaching %s.\n", __func__, sl->name);
- while (atomic_read(&sl->refcnt))
+ while (atomic_read(&sl->refcnt)) {
+ set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(10);
+ }
sysfs_remove_bin_file (&sl->dev.kobj, &sl->attr_bin);
device_remove_file(&sl->dev, &sl->attr_name);
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2004-09-27 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-20 23:59 [Kernel-janitors] [PATCH 2.6.9-rc2 4/4] mtd/cfi_cmdset_0020: Nishanth Aravamudan
2004-09-24 23:20 ` [Kernel-janitors] [PATCH 2.6.9-rc2 4/4] pci hotplug/shpchp: replace Nishanth Aravamudan
2004-09-27 17:28 ` [Kernel-janitors] [PATCH 2.6.9-rc2 4/4] sbus/envctrl: replace Nishanth Aravamudan
2004-09-27 23:20 ` Nishanth Aravamudan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040927232029.GA1617@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.