From: "John W. Linville" <linville@tuxdriver.com>
To: akpm@osdl.org
Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: [patch 2.6.9-rc2] 3c59x: do not mask reset of aism logic at rmmod
Date: Tue, 28 Sep 2004 14:54:55 -0400 [thread overview]
Message-ID: <20040928145455.C12480@tuxdriver.com> (raw)
Some (earlier?) versions of the 3c905(B) card get confused and refuse to
work again after the 3c59x module is removed (even after reloading the
module). Changing vortex_remove_one() to allow the auto-initialize
state machine logic to be reset when the module is removed alleviates
this problem.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
See http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=133388 for more
details.
If anyone can suggest a better way to fix this problem, please do so.
I'll be happy to pursue it.
drivers/net/3c59x.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
This patch should apply (with a little fuzz) to 2.4 as well...
--- linux-2.6/drivers/net/3c59x.c.orig
+++ linux-2.6/drivers/net/3c59x.c
@@ -3162,7 +3162,7 @@ static void __devexit vortex_remove_one
pci_restore_state(VORTEX_PCI(vp), vp->power_state);
}
/* Should really use issue_and_wait() here */
- outw(TotalReset|0x14, dev->base_addr + EL3_CMD);
+ outw(TotalReset|0x04, dev->base_addr + EL3_CMD);
pci_free_consistent(pdev,
sizeof(struct boom_rx_desc) * RX_RING_SIZE
next reply other threads:[~2004-09-28 20:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-28 18:54 John W. Linville [this message]
2004-09-29 17:16 ` [patch 2.6.9-rc2] 3c59x: do not mask reset of aism logic at rmmod Donald Becker
2004-09-30 13:14 ` John W. Linville
2004-10-07 17:46 ` John W. Linville
2004-10-08 16:39 ` [patch 2.6.9-rc3] 3c59x: reload EEPROM values at rmmod for needy cards John W. Linville
2004-10-15 19:33 ` Jeff Garzik
2004-10-15 21:12 ` Andrew Morton
2004-10-08 16:44 ` [patch 2.4.28-pre3] " John W. Linville
2004-10-17 15:05 ` [patch 2.6.9-rc2] 3c59x: remove EEPROM_RESET for 3c905B John W. Linville
2004-10-17 15:20 ` [patch 2.4.28-pre3] " John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040928145455.C12480@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.