From: Christoph Hellwig <hch@infradead.org>
To: "Kilau, Scott" <Scott_Kilau@digi.com>
Cc: linux-kernel@vger.kernel.org, wenxiong@us.ibm.com
Subject: Re: [PATCH 2.6.8.1] drivers/char: New serial driver.
Date: Tue, 28 Sep 2004 21:16:02 +0100 [thread overview]
Message-ID: <20040928211602.B5355@infradead.org> (raw)
In-Reply-To: <71A17D6448EC0140B44BCEB8CD0DA36E04B9D774@minimail.digi.com>; from Scott_Kilau@digi.com on Mon, Sep 27, 2004 at 03:03:32PM -0500
On Mon, Sep 27, 2004 at 03:03:32PM -0500, Kilau, Scott wrote:
> I am submitting a new serial driver for the 2.6 series of kernels.
>
> Description:
> Digi serial driver for the Digi Neo and Classic PCI serial port
> products.
- you pci handling is rather bogus. You must handle all initialization
from ->probe and all teardown from ->remove. No fuzzing with board
count please - if pci_module_init returned success the driver must
stay loaded
- why is this one driver and not two? Please split it into one driver
for each hardware type
- the procfs/sysctl support is rather gross. For sysctl please use
simple tabls like everyone else (e.g. look at fs/xfs/linux-2.6/xfs_systl.c)
Also new procfs entries are discouraged in general, but if you absolutely
need them use the fs/seq_file.c interface
- please convert to Russell's serial_core interface (drivers/serial),
we already have far more copies of the old serial driver munged into
various driver than nessecary
- if you want compat code please always emulted older apis on old
ones.
next prev parent reply other threads:[~2004-09-28 20:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-27 20:03 [PATCH 2.6.8.1] drivers/char: New serial driver Kilau, Scott
2004-09-27 20:31 ` Russell King
2004-09-28 20:16 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-09-28 20:09 Kilau, Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040928211602.B5355@infradead.org \
--to=hch@infradead.org \
--cc=Scott_Kilau@digi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.