From: Alan Cox <alan@redhat.com>
To: linux-kernel@vger.kernel.org, akpm@osdl.org, jgarzik@pobox.com
Subject: PATCH: 3c59x 00:00:00:00:00:00 MAC failure
Date: Wed, 29 Sep 2004 12:30:23 -0400 [thread overview]
Message-ID: <20040929163023.GA17899@devserv.devel.redhat.com> (raw)
The 3com EEPROM has a checksum but unfortunately it seems that a zapped
EEPROM returning all zero values passes the checksum test fine and we try
and use it.
--- drivers/net/3c59x.c~ 2004-09-29 17:23:42.964453264 +0100
+++ drivers/net/3c59x.c 2004-09-29 17:28:40.358242536 +0100
@@ -1295,6 +1295,13 @@
for (i = 0; i < 6; i++)
printk("%c%2.2x", i ? ':' : ' ', dev->dev_addr[i]);
}
+ /* Unfortunately an all zero eeprom passes the checksum and this
+ gets found in the wild in failure cases. Crypto is hard 8) */
+ if (memcmp(dev->dev_addr, "\0\0\0\0\0", 6) == 0) {
+ retval = -EINVAL;
+ printk(KERN_ERR "*** EEPROM MAC address is invalid.\n");
+ goto free_ring; /* With every pack */
+ }
EL3WINDOW(2);
for (i = 0; i < 6; i++)
outb(dev->dev_addr[i], ioaddr + i);
next reply other threads:[~2004-09-29 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-29 16:30 Alan Cox [this message]
2004-09-29 16:45 ` PATCH: 3c59x 00:00:00:00:00:00 MAC failure Russell King
2004-09-29 16:52 ` Jeff Garzik
2004-09-29 15:58 ` Alan Cox
2004-09-29 17:07 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040929163023.GA17899@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.