From: Greg KH <greg@kroah.com>
To: Roland Dreier <roland@topspin.com>
Cc: pj@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][2/2] [take 2] USB: use add_hotplug_env_var in core/usb.c
Date: Wed, 29 Sep 2004 17:21:01 -0700 [thread overview]
Message-ID: <20040930002100.GA27439@kroah.com> (raw)
In-Reply-To: <200409281919.8RXPZodVBIYTqtXg@topspin.com>
On Tue, Sep 28, 2004 at 07:19:34PM -0700, Roland Dreier wrote:
> Use the new add_hotplug_env_var() function in drivers/usb/core/usb.c.
> In addition to cleaning up the code, this fixes a (probably harmless)
> bug here: for each value added to the environment, the code did
>
> length += sprintf(...);
>
> and then
>
> scratch += length;
>
> which means that we skip the sum of the lengths of all the values
> we've put so far, rather than just the length of the value we just
> put. This is probably harmless since we're unlikely to run out of
> space but if nothing else it's setting a bad example....
>
> I've tested this on a system with USB floppy and CD-ROM; hotplug gets
> the same environment with the patch as without.
Applied, thanks.
greg k-h
next prev parent reply other threads:[~2004-09-30 0:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-29 2:19 [PATCH][0/2] [take 2] Hotplug variable patches Roland Dreier
2004-09-29 2:19 ` [PATCH][1/2] [take 2] kobject: add add_hotplug_env_var Roland Dreier
2004-09-29 2:19 ` [PATCH][2/2] [take 2] USB: use add_hotplug_env_var in core/usb.c Roland Dreier
2004-09-30 0:21 ` Greg KH [this message]
2004-09-30 0:18 ` [PATCH][1/2] [take 2] kobject: add add_hotplug_env_var Greg KH
2004-09-30 1:16 ` Roland Dreier
2004-09-29 3:30 ` [PATCH][0/2] [take 2] Hotplug variable patches Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040930002100.GA27439@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=roland@topspin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.