From: Andi Kleen <ak@muc.de>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Readd panic blinking in 2.6
Date: 30 Sep 2004 10:42:24 +0200
Date: Thu, 30 Sep 2004 10:42:24 +0200 [thread overview]
Message-ID: <20040930084224.GA28779@muc.de> (raw)
In-Reply-To: <20040929132134.GA3770@ucw.cz>
>
> Something like
>
> spin_lock_irqsave(&i8042_lock, flags);
> i8042_flush();
> i8042_ctr &= ~I8042_CTR_KBDINT & ~I8042_CTR_AUXINT;
> i8042_command(&i8042_ctr, I8042_CMD_CTL_WCTR);
> i8042_wait_write();
> i8042_write_data(0xed);
> i8042_wait_read();
> i8042_flush();
> i8042_wait_write();
> i8042_write_data(led);
> i8042_wait_read();
> i8042_flush();
> spin_unlock_irqrestore(&i8042_lock, flags);
>
> would be safer and more correct.
That all takes far too many locks. The risk of deadlocking during
panic is too great. I think the delay is fine (worked great under 2.4),
just need to fix the IBF issue you mentioned.
-Andi
next prev parent reply other threads:[~2004-09-30 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-29 13:05 [PATCH] Readd panic blinking in 2.6 Andi Kleen
2004-09-29 13:21 ` Vojtech Pavlik
2004-09-30 8:42 ` Andi Kleen [this message]
2004-09-30 9:06 ` Vojtech Pavlik
2004-09-29 22:05 ` Tonnerre
2004-09-30 8:01 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040930084224.GA28779@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.