From: Jens Axboe <axboe@suse.de>
To: Shailabh Nagar <nagar@watson.ibm.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][1/1] Per-priority statistics for CFQ w/iopriorities 2.6.8.1
Date: Thu, 30 Sep 2004 16:20:04 +0200 [thread overview]
Message-ID: <20040930142004.GB3251@suse.de> (raw)
In-Reply-To: <415C1643.8000605@watson.ibm.com>
On Thu, Sep 30 2004, Shailabh Nagar wrote:
> Jens Axboe wrote:
> >Hi,
> >
> >Missed this patch the first time over (thank you lwn :-) - why are you
> >using atomic counters? In all the paths you set them, you already have
> >the queue lock.
> >
>
> Thats right, there's no need for them. I used these instinctively....
> Will fix in next version, unless (hint, hint) you're taking a look at
> adding priorities back to mainline's CFQ.
It will never be for the mainline cfq, that is a dead code base. -mm has
a first stab at a cfq v2 with persistent io contexts, the priority based
code will go on top of that.
--
Jens Axboe
next prev parent reply other threads:[~2004-09-30 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-30 6:59 [PATCH][1/1] Per-priority statistics for CFQ w/iopriorities 2.6.8.1 Jens Axboe
2004-09-30 14:20 ` Shailabh Nagar
2004-09-30 14:20 ` Jens Axboe [this message]
2004-09-30 14:47 ` Shailabh Nagar
2004-09-30 14:49 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2004-09-24 23:41 Shailabh Nagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040930142004.GB3251@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nagar@watson.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.