From: Dave Jones <davej@redhat.com>
To: Greg KH <greg@kroah.com>
Cc: ak@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix improper use of pci_module_init() in drivers/char/agp/amd64-agp.c
Date: Fri, 1 Oct 2004 02:56:08 +0100 [thread overview]
Message-ID: <20041001015558.GA8657@redhat.com> (raw)
In-Reply-To: <20040930184248.GA17546@kroah.com>
On Thu, Sep 30, 2004 at 11:42:48AM -0700, Greg KH wrote:
> Hi,
Hi Greg,
> In going through the tree and auditing the usage of pci_module_init(), I
> noticed that the amd64-agp driver was assuming that the return value of
> this function could be greater than 0 (which is what could happen in 2.2
> and 2.4 kernels.) As this is no longer true, I think the following
> patch is correct.
>
> I can add this to my bk-pci tree if you wish, otherwise feel free to
> send it upwards.
I'm going through all kinds of busyness due to a relocation right now,
so feel free to push this yourself after you and Andi are done beating
out the details.
Dave
prev parent reply other threads:[~2004-10-01 1:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-30 18:42 [PATCH] fix improper use of pci_module_init() in drivers/char/agp/amd64-agp.c Greg KH
2004-09-30 19:20 ` Andi Kleen
2004-09-30 19:59 ` Greg KH
2004-09-30 20:06 ` Andi Kleen
2004-09-30 21:05 ` Greg KH
2004-09-30 20:09 ` Greg KH
2004-10-01 1:56 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041001015558.GA8657@redhat.com \
--to=davej@redhat.com \
--cc=ak@suse.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.