All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell Coker <russell@coker.com.au>
To: Daniel J Walsh <dwalsh@redhat.com>
Cc: SELinux <SELinux@tycho.nsa.gov>
Subject: Re: Today's diffs
Date: Sat, 2 Oct 2004 01:25:00 +1000	[thread overview]
Message-ID: <200410020125.00090.russell@coker.com.au> (raw)
In-Reply-To: <415CAFC5.8020505@redhat.com>

On Fri, 1 Oct 2004 11:15, Daniel J Walsh <dwalsh@redhat.com> wrote:
> New tvtime and vpnc
> Fixes for mozilla and inetd daemons

allow getty_t initrc_devpts_t:chr_file { read write };

How do you trigger this?  There doesn't seem to be a good reason for getty to 
have such access.  Bug in init?

-# /usr/sbin/sendmail asks for w access to utmp, but it will operate
-# correctly without it.  Do not audit write and lock denials to utmp.
-allow sendmail_t initrc_var_run_t:file { getattr read };
-dontaudit sendmail_t initrc_var_run_t:file { lock write };
+# /usr/sbin/sendmail asks for w access to utmp
+allow sendmail_t initrc_var_run_t:file { getattr read lock write };

Why does sendmail need lock and write access to initrc_var_run_t?

+allow user_tvtime_t xdm_tmp_t:dir { search };

The above rule is redundant, you also have it in 
macros/program/tvtime_macros.te.

Also you have put in comments indicating that several programs have been 
compiled with SSP (Stack Smashing Protection).  If the Fedora GCC packages 
support SSP then we should enable it for newrole etc.

+allow udev_t domain:dir r_dir_perms;

Why does udev need this?  Why would it need read access to the directory but 
not to files inside it?

+/usr/bin/chage         --      system_u:object_r:passwd_exec_t

This is wrong.  It should be admin_passwd_exec_t.  A regular user should not 
execute this.

--- nsapolicy/macros/global_macros.te   2004-09-22 16:19:13.000000000 -0400
+++ policy-1.17.25/macros/global_macros.te      2004-09-30 20:59:57.315488479 
-0400
@@ -287,6 +287,7 @@
 allow $1_t device_t:dir { getattr search };
 allow $1_t null_device_t:chr_file rw_file_perms;
 dontaudit $1_t console_device_t:chr_file rw_file_perms;
+dontaudit $1_t unpriv_userdomain:fd use;
 
 r_dir_file($1_t, sysfs_t) 

How do you trigger this?  Is it related to the bug in su where su does not 
re-open the terminal when changing role?  I expect that fixing su will fix 
this.

+allow $1_lpr_t $1_mozilla_t:tcp_socket { read write };
+allow $1_lpr_t $1_mozilla_t:unix_stream_socket { read write };

Looks like mozilla is too buggy to close it's file handles before spawning 
lpr.  There's no reason for lpr to access a tcp or unix socket that mozilla 
has created, they should be dontaudit rules.

-- 
http://www.coker.com.au/selinux/   My NSA Security Enhanced Linux packages
http://www.coker.com.au/bonnie++/  Bonnie++ hard drive benchmark
http://www.coker.com.au/postal/    Postal SMTP/POP benchmark
http://www.coker.com.au/~russell/  My home page

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

  reply	other threads:[~2004-10-01 15:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-01  1:15 Today's diffs Daniel J Walsh
2004-10-01 15:25 ` Russell Coker [this message]
2004-10-01 15:36   ` Daniel J Walsh
2004-10-01 16:36     ` Russell Coker
2004-10-01 17:57       ` Russell Coker
  -- strict thread matches above, loose matches on Subject: below --
2004-10-06 17:54 Today's Diffs Daniel J Walsh
2004-10-06 20:24 ` James Carter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200410020125.00090.russell@coker.com.au \
    --to=russell@coker.com.au \
    --cc=SELinux@tycho.nsa.gov \
    --cc=dwalsh@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.