All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olh@suse.de>
To: Alan Cox <alan@redhat.com>, Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: missing tty in sclp_tty.c and sclp_vt220.c
Date: Sat, 2 Oct 2004 14:52:20 +0200	[thread overview]
Message-ID: <20041002125220.GA19908@suse.de> (raw)

Alan,

what 'tty' did you mean here? gcc says its undeclared.

should that be sclp_tty and sclp_vt220_tty?

diff -Nru a/drivers/s390/char/sclp_tty.c b/drivers/s390/char/sclp_tty.c
--- a/drivers/s390/char/sclp_tty.c      2004-09-29 20:07:09 -07:00
+++ b/drivers/s390/char/sclp_tty.c      2004-09-29 20:07:09 -07:00
@@ -277,10 +277,7 @@
        wake_up(&sclp_tty_waitq);
        /* check if the tty needs a wake up call */
        if (sclp_tty != NULL) {
-               if ((sclp_tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
-                   sclp_tty->ldisc.write_wakeup)
-                       (sclp_tty->ldisc.write_wakeup)(sclp_tty);
-               wake_up_interruptible(&sclp_tty->write_wait);
+               tty_wakeup(tty);
        }
 }

diff -Nru a/drivers/s390/char/sclp_vt220.c b/drivers/s390/char/sclp_vt220.c
--- a/drivers/s390/char/sclp_vt220.c    2004-09-29 20:06:20 -07:00
+++ b/drivers/s390/char/sclp_vt220.c    2004-09-29 20:06:20 -07:00
@@ -139,10 +139,7 @@
        wake_up(&sclp_vt220_waitq);
        /* Check if the tty needs a wake up call */
        if (sclp_vt220_tty != NULL) {
-               if ((sclp_vt220_tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
-                   (sclp_vt220_tty->ldisc.write_wakeup != NULL))
-                       (sclp_vt220_tty->ldisc.write_wakeup)(sclp_vt220_tty);
-               wake_up_interruptible(&sclp_vt220_tty->write_wait);
+               tty_wakeup(tty);
        }
 }



-- 
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG

             reply	other threads:[~2004-10-02 12:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-02 12:52 Olaf Hering [this message]
2004-10-02 14:56 ` missing tty in sclp_tty.c and sclp_vt220.c Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041002125220.GA19908@suse.de \
    --to=olh@suse.de \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.