All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: "Josef 'Jeff' Sipek" <jeffpc@optonline.net>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org,
	trivial@rustcorp.com.au, rusty@rustcorp.com.au
Subject: Re: [PATCH 2.6][resend] Add DEVPATH env variable to hotplug helper call
Date: Sun, 3 Oct 2004 16:20:12 -0700	[thread overview]
Message-ID: <20041003162012.79296b37.akpm@osdl.org> (raw)
In-Reply-To: <20041003100857.GB5804@optonline.net>

"Josef 'Jeff' Sipek" <jeffpc@optonline.net> wrote:
>
> Add $DEVPATH to the environmental variables during /sbin/hotplug call.
> 
>  Josef 'Jeff' Sipek.
> 
>  Signed-off-by: Josef 'Jeff' Sipek <jeffpc@optonline.net>
> 
> 
>  diff -Nru a/kernel/cpu.c b/kernel/cpu.c
>  --- a/kernel/cpu.c	2004-09-24 13:08:57 -04:00
>  +++ b/kernel/cpu.c	2004-09-24 13:08:57 -04:00
>  @@ -61,13 +61,13 @@
>    * cpu' with certain environment variables set.  */
>   static int cpu_run_sbin_hotplug(unsigned int cpu, const char *action)

I don't think this function should exist at all.  We already have kobjects
which represent the CPUs so it should be possible to find that kobject and
use kobject_hotplug() on it.  That gives you your $DEVPATH.

Does CPU hotplug behave correctly wrt /sys/devices/system/cpu?  Given that
register_cpu() is still marked __init, I assume not.

  reply	other threads:[~2004-10-03 23:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-03 10:08 [PATCH 2.6][resend] Add DEVPATH env variable to hotplug helper call Josef 'Jeff' Sipek
2004-10-03 23:20 ` Andrew Morton [this message]
2004-10-04 17:22   ` Keshavamurthy Anil S
2004-10-04 19:37     ` Andrew Morton
2004-10-04 19:43       ` Keshavamurthy Anil S
2004-10-05  8:25         ` Keshavamurthy Anil S
2004-10-05 17:18           ` Andrew Morton
2004-10-05 17:27             ` Keshavamurthy Anil S
2004-10-05 17:47               ` Andrew Morton
2004-10-05 18:01                 ` Keshavamurthy Anil S
2004-10-05 18:23                   ` Andrew Morton
2004-10-05 19:02                     ` Keshavamurthy Anil S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041003162012.79296b37.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=jeffpc@optonline.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@osdl.org \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.