From: Jens Axboe <axboe@suse.de>
To: Luke Kenneth Casson Leighton <lkcl@lkcl.net>,
linux-kernel@vger.kernel.org
Subject: Re: [bug] 2.6.8: CDROM_SEND_PACKET ioctls failing as non-root on ide scsi drives
Date: Mon, 4 Oct 2004 15:55:44 +0200 [thread overview]
Message-ID: <20041004135544.GW2287@suse.de> (raw)
In-Reply-To: <6uu0tad24s.fsf@zork.zork.net>
On Mon, Oct 04 2004, Sean Neakums wrote:
> Jens Axboe <axboe@suse.de> writes:
>
> > On Mon, Oct 04 2004, Sean Neakums wrote:
> >> CDROM_SEND_PACKET calls down to sg_io, which calls verify_command,
> >> which will not permit anyone but root to use any unrecognised
> >> commands. GET CONFIGURATION does not seems to be one of those
> >> recognised. This check for unrecognised commands is a fairly recent
> >> addition, IIRC.
> >
> > 2.6.8 didn't have any command granularity, you must be root to issue any
> > comand there.
>
> I was looking at 2.6.8.1 when I wrote the above, although it's
> possible my eye skipped over something.
>
> verify_command certainly seems to do the check:
>
> http://lxr.linux.no/source/drivers/block/scsi_ioctl.c?v=2.6.8.1#L113
>
> And it looks the same in the 2.6.8 tree I have here, too.
You are right, it was added before, my recollection of the events
apparently isn't so good either. You are right in that GET_CONFIGURATION
was added later, post 2.6.8 release.
> (Not trying to be an ass, just concerned about my reading comprehension.)
:-)
--
Jens Axboe
next prev parent reply other threads:[~2004-10-04 13:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-04 13:09 [bug] 2.6.8: CDROM_SEND_PACKET ioctls failing as non-root on ide scsi drives Luke Kenneth Casson Leighton
2004-10-04 12:59 ` Jens Axboe
2004-10-04 14:38 ` Luke Kenneth Casson Leighton
2004-10-04 13:30 ` Sean Neakums
2004-10-04 13:36 ` Jens Axboe
2004-10-04 13:49 ` Sean Neakums
2004-10-04 13:55 ` Jens Axboe [this message]
2004-10-04 14:23 ` Luke Kenneth Casson Leighton
2004-10-04 14:20 ` Luke Kenneth Casson Leighton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041004135544.GW2287@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkcl@lkcl.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.