Re: finally solve the bad sysfs-timing for all of us

[Kay Sievers <kay.sievers@vrfy.org>]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

On Tue, Oct 05, 2004 at 01:51:02PM -0700, Greg KH wrote:
> On Tue, Sep 21, 2004 at 10:04:57PM +0200, Kay Sievers wrote:
> > > 
> > > For now, it logs the result of the waiting to syslog, to catch any
> > > device, that needs special treatment.
> 
> Applied, thanks.

Sorry, I left my debug code in. We don't need to log a successful operation.
On failure we log and ask to report the device, so we hopefully collect all
unusual device representations over the time and can put in in the built-in
exception lists.

Thanks,
Kay

[-- Attachment #2: udev-wait_for_sysfs-debug-01.patch --]
[-- Type: text/plain, Size: 805 bytes --]

===== wait_for_sysfs.c 1.1 vs edited =====
--- 1.1/wait_for_sysfs.c	2004-09-21 22:00:29 +02:00
+++ edited/wait_for_sysfs.c	2004-10-06 02:16:27 +02:00
@@ -206,6 +206,8 @@ int main(int argc, char *argv[], char *e
 	int loop;
 	int rc = 0;
 
+	init_logging("wait_for_sysfs");
+
 	if (argc != 2) {
 		dbg("error: subsystem");
 		return 1;
@@ -326,9 +328,11 @@ int main(int argc, char *argv[], char *e
 
 exit:
 	if (rc == 0)
-		info("result: waiting for sysfs successful '%s'", devpath);
+		dbg("result: waiting for sysfs successful '%s'", devpath);
 	else
-		info("result: waiting for sysfs failed '%s'", devpath);
+		info("error: wait_for_sysfs needs an update to handle the device '%s' "
+		     "properly, please report to <linux-hotplug-devel@lists.sourceforge.net>",
+		     devpath);
 
 	return rc;
 }