Re: 2.6.6-mm1 Oops with dummy network device (sysfs related?)

[Maneesh Soni <maneesh@in.ibm.com>]

On Mon, May 10, 2004 at 11:35:00PM +0000, Richard A Nelson wrote:
> On Mon, 10 May 2004, Stephen Hemminger wrote:
> 
> > It would be easier to know what is wrong, if you said what you
> > did that started the problem.  Looks like ifrename or something
> > like that.
> 
> hrm, been trying to track that down (several oopses later...)
> 
> the modprobe dummy worked ok (and is seen in the log)
> the next command is 'ip link set name ipsec0 dev dummy0'
> and I've yet to get passed that

ok it is sysfs related and because of the backing store patches from me.

And here is the fix. Hope this solves your problem. 


Thanks
Maneesh

o Fix sysfs_rename_dir(). The sysfs_lookup() does not hash
  negative dentries so just hash it before calling d_move

 fs/sysfs/dir.c |    1 +
 1 files changed, 1 insertion(+)

diff -puN fs/sysfs/dir.c~sysfs-backing-store-sysfs_rename_dir-fix fs/sysfs/dir.c
--- linux-2.6.6-mm1/fs/sysfs/dir.c~sysfs-backing-store-sysfs_rename_dir-fix	2004-10-06 15:21:37.000000000 +0530
+++ linux-2.6.6-mm1-maneesh/fs/sysfs/dir.c	2004-10-06 15:22:03.000000000 +0530
@@ -314,6 +314,7 @@ void sysfs_rename_dir(struct kobject * k
 	new_dentry = sysfs_get_dentry(parent, new_name);
 	if (!IS_ERR(new_dentry)) {
 		if (!new_dentry->d_inode) {
+			d_add(new_dentry, NULL);
 			d_move(kobj->dentry, new_dentry);
 			kobject_set_name(kobj,new_name);
 		}

_


-- 
Maneesh Soni
Linux Technology Center, 
IBM Software Lab, Bangalore, India
email: maneesh@in.ibm.com
Phone: 91-80-25044999 Fax: 91-80-25268553
T/L : 9243696