From: "David S. Miller" <davem@davemloft.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: jgarzik@pobox.com, acme@conectiva.com.br, corey@world.std.com,
netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: Raylink/WebGear testing - ray_cs.c iomem bug?
Date: Wed, 6 Oct 2004 10:54:53 -0700 [thread overview]
Message-ID: <20041006105453.5f7d1888.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0410061032410.8290@ppc970.osdl.org>
On Wed, 6 Oct 2004 10:43:50 -0700 (PDT)
Linus Torvalds <torvalds@osdl.org> wrote:
> That cleanup in turn seems to show that the driver was fundamentally buggy
> in a way that really surprises me: it adds "CCS_BASE" to the PCI window
> base in order to get to both the "struct ccs" pointer _and_ to the "struct
> rcs" pointer.
In the spot where this occurs, it adds both CCS_BASE and
'rcsindex' to the sram base, and only when rcsindex >= NUMBER_OF_CCS.
NUMBER_OF_CCS is 64, and the difference between CCS_BASE and RCS_BASE
is 0x400 so this really doesn't account for anything.
I can't see how you've changed the behavior, so it should work as well
as it did before your changes.
Sorry, I don't have a ray_cs handy :)
next prev parent reply other threads:[~2004-10-06 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-06 17:43 Raylink/WebGear testing - ray_cs.c iomem bug? Linus Torvalds
2004-10-06 17:54 ` David S. Miller [this message]
2004-10-06 18:06 ` Linus Torvalds
2004-10-06 18:14 ` David S. Miller
2004-10-06 17:56 ` Linus Torvalds
2004-10-06 19:16 ` Jeff Garzik
2004-10-06 21:59 ` Thomas Davis
2004-10-07 5:46 ` Thomas Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041006105453.5f7d1888.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@conectiva.com.br \
--cc=corey@world.std.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.