From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.33) id 1CF7hI-0005P8-Le for mharc-grub-devel@gnu.org; Wed, 06 Oct 2004 05:02:56 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CF7hD-0005OR-VJ for grub-devel@gnu.org; Wed, 06 Oct 2004 05:02:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CF7hC-0005Nv-BS for grub-devel@gnu.org; Wed, 06 Oct 2004 05:02:50 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CF7hC-0005Nl-2w for grub-devel@gnu.org; Wed, 06 Oct 2004 05:02:50 -0400 Received: from [212.43.237.68] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CF7Zu-00050n-2d for grub-devel@gnu.org; Wed, 06 Oct 2004 04:55:18 -0400 Received: from localhost (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id A051BFF9F3DC for ; Wed, 6 Oct 2004 10:55:17 +0200 (CEST) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Wed, 6 Oct 2004 10:55:38 +0200 User-Agent: KMail/1.6.1 References: <200410060329.44046.tim.lists@majoroak.f2s.com> In-Reply-To: <200410060329.44046.tim.lists@majoroak.f2s.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit Message-Id: <200410061055.38925.okuji@enbug.org> Subject: Re: [patch] Widening terminal coordinates, and reading terminal size. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Oct 2004 09:02:52 -0000 On Wednesday 06 October 2004 04:29, Timothy Baldwin wrote: > Here is a patch to widen terminal coordinates from grub_uint8_t to > unsigned, change grub_getxy to return values via pointers. I have > also added grub_getsizexy to read the terminal size. The PPC > implementation is a dummy function, an the PC version assumes a > height of 25. Improvements would be welcome. I agree with your idea, but the name `getsizexy' is not very good, since the return values are not coordinates. getsize or getgeometry might be better. What do you think? > * include/grub/term.h > (grub_getsizexy, grub_term::grub_getsizexy): New prototypes. This does not follow the convention. First, you should not specify multiple functions in an entry. Please split it. Also, grub_term::grub_getsizexy is not good. It should be: (struct grub_term): Added a new member `grub_getsizexy'. > (grub_getxy, grub_term::grub_getxy): Returns via pointers to > unsigned, instead of packed into a 16-bit value, all callers > and implementations updated. Likewise. > (grub_gotoxy, grub_term::grub_gotoxy): Arguements are now unsigned. Likewise. > * term/i386/pc/console.c kern/i386/pc/startup.S > include/grub/i386/pc/console.h (grub_console_getsizexy): New > function You should not mention multiple files at a time. Please split it. And, you don't describe your change of grub_console_getxy. > * util/console.c (grub_ncurses_getsizexy): New function Please append a period. Okuji