From: Andi Kleen <ak@muc.de>
To: Zachary Amsden <zach@vmware.com>
Cc: linux-kernel@vger.kernel.org, Riley@Williams.Name,
davej@codemonkey.org.uk, hpa@zytor.com,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] i386/gcc bug with do_test_wp_bit
Date: 6 Oct 2004 13:55:50 +0200
Date: Wed, 6 Oct 2004 13:55:50 +0200 [thread overview]
Message-ID: <20041006115550.GA58628@muc.de> (raw)
In-Reply-To: <41634E21.6020808@vmware.com>
On Tue, Oct 05, 2004 at 06:45:05PM -0700, Zachary Amsden wrote:
> Playing around with gcc 3.3.3, I compiled a 2.6 series kernel for i386
> and discovered it panics on boot. The problem was gcc 3.3.3 can inline
> functions even if declared after their call sites. This causes i386 to
> not boot, since do_test_wp_bit() must not exist in the __init section.
> Similar problems may exist in the boot code for other architectures, but
> I can't confirm that at this time. x86_64 is not affected.
That should have been fixed long ago by sorting the exception
table. I checked and the code is still there:
asmlinkage void __init start_kernel(void)
{
...
sort_main_extable();
Something must be rotten in your setup. I definitely don't see the
same problems with a unit-at-a-time 3.3 gcc.
Can you double check that the sort is really done?
The patch is imho not needed.
-Andi
next prev parent reply other threads:[~2004-10-06 11:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-06 1:45 [PATCH] i386/gcc bug with do_test_wp_bit Zachary Amsden
2004-10-06 2:05 ` Linus Torvalds
2004-10-06 3:19 ` Zachary Amsden
2004-10-06 11:55 ` Andi Kleen [this message]
2004-10-06 19:34 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041006115550.GA58628@muc.de \
--to=ak@muc.de \
--cc=Riley@Williams.Name \
--cc=davej@codemonkey.org.uk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.