From: "David S. Miller" <davem@redhat.com>
To: akepner@sgi.com
Cc: jgarzik@pobox.com, netdev@oss.sgi.com
Subject: Re: [RFC] using mmiowb() in dev->poll() method
Date: Wed, 6 Oct 2004 12:10:31 -0700 [thread overview]
Message-ID: <20041006121031.488f33c5.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0410061116160.15729-100000@localhost.localdomain>
On Wed, 6 Oct 2004 11:24:19 -0700 (PDT)
<akepner@sgi.com> wrote:
> Currently, returning 0 from "dev->poll()" indicates that the
> PIO write which enables interrupts has been flushed to the NIC
> (or at least that's my understanding.) The change below allows
> "dev->poll()" to return with that PIO write pending, but not
> necessarily flushed. This allows a potentially expensive PIO
> flush to be avoided. I've found that this can significantly
> reduce CPU utilization and improve throughput.
Of course, this is a known area for exploration to some of
us already.
There is a similar place for this kind of toying around in
tg3_interrupt()'s disabling of the chips IRQs. e1000 optimizes
things in this area, last time I checked.
You have to be really careful when doing things like this.
I think your dev->poll() case would work. In theory the
write can be posted for a long time but I doubt that matters
in practice.
I intend to play around in this area of the tg3 driver some time
soon.
prev parent reply other threads:[~2004-10-06 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-06 18:24 [RFC] using mmiowb() in dev->poll() method akepner
2004-10-06 19:10 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041006121031.488f33c5.davem@redhat.com \
--to=davem@redhat.com \
--cc=akepner@sgi.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.