From: Pavel Machek <pavel@ucw.cz>
To: Steve M <stevenm@umd.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RadeonFB ACPI S3 patch fixed to not break S4. 2.6.8.1, 2.6.7
Date: Wed, 6 Oct 2004 14:35:03 +0200 [thread overview]
Message-ID: <20041006123503.GA19967@elf.ucw.cz> (raw)
In-Reply-To: <1096868582.10456.9.camel@stevenm-laptop.student.umd.edu>
Hi!
> This applies to the patch written by Ole Rohne, ole.rohne_AT_cern.ch
> This applies to Radeon Mobility cards (mine is M9000 but it could work
> for others) on certain laptops that don't reinitialize the video BIOS
> upon resume (Mine is a Dell Insipron 600m but there are others).
>
> This patch reinitializes the Radeon BIOS upon resume from an ACPI sleep
> state other than S4.
>
> The original patch reinitialized the video bios from any ACPI resume,
> but this broke suspending to S4. The machine would begin to suspend,
> then the display would go dark and the system would become unresponsive.
>
> I added an if statement to the part that patches radeon_pm.c so that it
> would NOT try to reinitialize the video BIOS if the machine is entering
> S4. This worked.
Ok.
> Given how much aggrivation this has given me, I figure submitting the
> new patch would be nice.
It needs to follow kernel coding style (see acpi sleep.c). On what
machine did you test it? I have machine (Arima) with radeon but ole's
patches did not work for me, I'll probably test this one too.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2004-10-06 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-04 5:43 [PATCH] RadeonFB ACPI S3 patch fixed to not break S4. 2.6.8.1, 2.6.7 Steve M
2004-10-06 12:35 ` Pavel Machek [this message]
2004-10-07 13:52 ` Stefan Schweizer
[not found] ` <1097134935.7805.1.camel@stevenm-laptop.student.umd.edu>
2004-10-07 15:39 ` Stefan Schweizer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041006123503.GA19967@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=stevenm@umd.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.