Re: linux 2.6.9-rc3: ub oops on device removal

[Pete Zaitcev <zaitcev@redhat.com>]

On Wed, 06 Oct 2004 21:50:06 +0200
Soeren Sonnenburg <kernel@nn7.de> wrote:

> I get this oops on kernel 2.6.9-rc3 on a 15" powerbook.
> 
> xmon trace screenshot is at:
> http://fortknox.dyndns.org/pics/oopses/ub.jpg

First you need to use -rc3-mm2 (it has some fixes), and then
add the appended patch which fixes your problem specifically.
The ub in 2.6.9-rc3 is not useable without these fixes.

-- Pete

--- linux-2.6.9-rc3-mm2/drivers/block/ub.c	2004-10-04 16:59:35.000000000 -0700
+++ linux-2.6.9-rc3-mm2-ub/drivers/block/ub.c	2004-10-04 17:01:08.000000000 -0700
@@ -842,7 +842,6 @@
 {
 	struct ub_dev *sc = urb->context;
 
-	del_timer(&sc->work_timer);
 	ub_complete(&sc->work_done);
 	tasklet_schedule(&sc->tasklet);
 }
@@ -853,6 +852,7 @@
 	unsigned long flags;
 
 	spin_lock_irqsave(&sc->lock, flags);
+	del_timer(&sc->work_timer);
 	ub_scsi_dispatch(sc);
 	spin_unlock_irqrestore(&sc->lock, flags);
 }