From: Matt Mackall <mpm@selenic.com>
To: Colin Leroy <colin@colino.net>
Cc: Andrew Morton <akpm@osdl.org>, netdev@oss.sgi.com
Subject: Re: [PATCH] Prevent netpoll hanging when link is down
Date: Wed, 6 Oct 2004 16:43:22 -0500 [thread overview]
Message-ID: <20041006214322.GG31237@waste.org> (raw)
In-Reply-To: <20041006232544.53615761@jack.colino.net>
On Wed, Oct 06, 2004 at 11:25:44PM +0200, Colin Leroy wrote:
> Hi,
>
> this patch fixes a (quite big) problem with netpoll: when link is down,
> it hangs.
>
> This patch fixes it. Tested with no carrier (no more hang) and with
> carrier (same behaviour as before).
[cc:ed to netdev]
Well this doesn't look unreasonable, but I haven't run into it with
the NICs I've tested. Nor have I seen this reported before. Which NICs
is this with?
> - if(!np || !np->dev || !netif_running(np->dev)) {
> + if(!np || !np->dev || !netif_running(np->dev) ||
> + !netif_carrier_ok(np->dev)) {
I wonder if netif_running is redundant if netif_carrier_ok.
--
Mathematics is the supreme nostalgia of our time.
next parent reply other threads:[~2004-10-06 21:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041006232544.53615761@jack.colino.net>
2004-10-06 21:43 ` Matt Mackall [this message]
2004-10-07 5:53 ` [PATCH] Prevent netpoll hanging when link is down Colin Leroy
2004-10-07 6:49 ` David S. Miller
2004-10-07 8:33 ` Colin Leroy
2004-10-07 8:45 ` Colin Leroy
2004-10-07 14:05 ` Colin Leroy
2004-10-07 18:28 ` David S. Miller
2004-10-07 18:41 ` Matt Mackall
2004-10-07 20:00 ` Colin Leroy
2004-10-07 18:43 ` Andi Kleen
2004-10-07 20:44 ` Colin Leroy
2004-10-07 21:45 ` Andi Kleen
2004-10-07 21:50 ` Matt Mackall
2004-10-07 22:07 ` David S. Miller
2004-10-07 23:43 ` Matt Mackall
2004-10-07 23:50 ` Andi Kleen
2004-10-08 6:46 ` Colin Leroy
2004-10-08 21:53 ` Matt Mackall
2004-10-08 7:06 ` Colin Leroy
2004-10-08 22:00 ` Matt Mackall
2004-10-08 22:18 ` Andrew Morton
2004-10-11 3:59 ` David S. Miller
2004-10-11 15:40 ` Andi Kleen
2004-10-11 16:22 ` Matt Mackall
2004-10-11 16:32 ` Andi Kleen
2004-10-11 16:36 ` Matt Mackall
2004-10-11 16:43 ` Andi Kleen
2004-10-11 16:58 ` Matt Mackall
2004-10-11 17:41 ` Andi Kleen
2004-10-11 20:45 ` Colin Leroy
[not found] ` <5cac192f0410181443303379e2@mail.gmail.com>
[not found] ` <5cac192f041018145824acce5a@mail.gmail.com>
[not found] ` <20041020161119.6e30efe5@pirandello>
[not found] ` <5cac192f0410200848179ccc81@mail.gmail.com>
2004-10-21 16:36 ` Colin Leroy
2004-10-24 15:22 ` Eric Lemoine
2004-10-07 22:08 ` David S. Miller
2004-10-08 6:54 ` Colin Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041006214322.GG31237@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=colin@colino.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.