All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Domsch <Matt_Domsch@dell.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	linux-kernel@vger.kernel.org, alan@redhat.com,
	david.balazic@hermes.si
Subject: Re: [PATCH 2.6.9-rc3-mm2] EDD: use EXTENDED READ command, add CONFIG_EDD_SKIP_MBR
Date: Wed, 6 Oct 2004 23:22:54 -0500	[thread overview]
Message-ID: <20041007042254.GA7325@lists.us.dell.com> (raw)
In-Reply-To: <20041006211605.17c1cb41.akpm@osdl.org>

On Wed, Oct 06, 2004 at 09:16:05PM -0700, Andrew Morton wrote:
> Jeff Garzik <jgarzik@pobox.com> wrote:
> >
> > > This also adds CONFIG_EDD_SKIP_MBR to eliminate reading the MBR on
> >  > each BIOS-presented disk, in case there are further problems in this
> >  > area.
> > 
> > 
> >  Build fails on x86-64:
> > 
> >  [...]
> >     SYSMAP  System.map
> >     SYSMAP  .tmp_System.map
> >     AS      arch/x86_64/boot/setup.o
> >  In file included from arch/x86_64/boot/setup.S:536:
> >  arch/i386/boot/edd.S:17: macro names must be identifiers
> >  make[1]: *** [arch/x86_64/boot/setup.o] Error 1
> >  make: *** [bzImage] Error 2
> 
> hm, works OK here.
> 
> Is it missing config.h?

No, that's pulled in by setup.S which #includes edd.S, on both i386
and x86_64.  Jeff, is it the parens around CONFIG_EDD_SKIP_MBR on that
line somehow?


--
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

  parent reply	other threads:[~2004-10-07  4:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-04 21:48 [PATCH 2.6.9-rc3-mm2] EDD: use EXTENDED READ command, add CONFIG_EDD_SKIP_MBR Matt Domsch
2004-10-07  4:01 ` Jeff Garzik
2004-10-07  4:16   ` Andrew Morton
2004-10-07  4:20     ` Jeff Garzik
2004-10-07  4:25       ` Matt Domsch
2004-10-07  4:22     ` Matt Domsch [this message]
2004-10-07  4:34 ` Jeff Garzik
2004-10-07  4:39 ` Jeff Garzik
2004-10-07  5:19   ` Matt Domsch
2004-10-07  5:32     ` Jeff Garzik
  -- strict thread matches above, loose matches on Subject: below --
2004-10-27 16:53 Matt_Domsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041007042254.GA7325@lists.us.dell.com \
    --to=matt_domsch@dell.com \
    --cc=akpm@osdl.org \
    --cc=alan@redhat.com \
    --cc=david.balazic@hermes.si \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.