From: "J. Bruce Fields" <bfields@fieldses.org>
To: NeilBrown <neilb@cse.unsw.edu.au>
Cc: Andrew Morton <akpm@osdl.org>, nfs@lists.sourceforge.net
Subject: Re: [PATCH kNFSd 1 of 9] Calls to break_lease in nfsd should be O_NONBLOCKing.
Date: Thu, 7 Oct 2004 16:18:56 -0400 [thread overview]
Message-ID: <20041007201856.GA30356@fieldses.org> (raw)
In-Reply-To: <E1C33uD-00042m-VA@notabene.cse.unsw.edu.au>
On Fri, Sep 03, 2004 at 12:34:25PM +1000, NeilBrown wrote:
>
> If we would block, we return "err-jukebox" for nfsv3,
> or just drop the request for v2.
Sorry, only just noticed there's a problem here:
> diff ./fs/nfsd/nfsproc.c~current~ ./fs/nfsd/nfsproc.c
> --- ./fs/nfsd/nfsproc.c~current~ 2004-09-03 11:34:26.000000000 +1000
> +++ ./fs/nfsd/nfsproc.c 2004-09-03 11:34:29.000000000 +1000
> @@ -586,6 +586,7 @@ nfserrno (int errno)
> { nfserr_dquot, -EDQUOT },
> #endif
> { nfserr_stale, -ESTALE },
> + { nfserr_jukebox, -EWOULDBLOCK },
> { nfserr_jukebox, -ETIMEDOUT },
> { nfserr_dropit, -EAGAIN },
> { nfserr_dropit, -ENOMEM },
Note that EWOULDBLOCK is defined to be EAGAIN in
include/asm-generic/errno.h, so the effect of this is to map EAGAIN to
nfserr_jukebox instead of nfserr_dropit.
The cache upcall deferral code depends on EAGAIN being mapped to
nfserr_dropit. So now whenever cache upcall deferral happens, the
client gets a nfserr_jukebox response, which isn't what we want.
--b.
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2004-10-07 20:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-03 2:34 [PATCH kNFSd 0 of 9] Introduction NeilBrown
2004-09-03 2:34 ` [PATCH kNFSd 1 of 9] Calls to break_lease in nfsd should be O_NONBLOCKing NeilBrown
2004-10-07 20:18 ` J. Bruce Fields [this message]
2004-09-03 2:34 ` [PATCH kNFSd 4 of 9] nfsd4: Support acl_support attribute NeilBrown
2004-09-03 2:34 ` [PATCH kNFSd 7 of 9] nfsd4: postpone release of stateowner on CLOSE NeilBrown
2004-09-03 2:34 ` [PATCH kNFSd 5 of 9] trivial cleanup of nfs4state.c NeilBrown
2004-09-03 2:34 ` [PATCH kNFSd 6 of 9] nfsd4 could leak a stateid in an error path NeilBrown
2004-09-03 2:34 ` [PATCH kNFSd 3 of 9] fix incorrect indentation in fh_verify NeilBrown
2004-09-03 2:34 ` [PATCH kNFSd 2 of 9] Return EACCES instead of ESTALE for certain filehandle lookup failures NeilBrown
2004-09-03 2:34 ` [PATCH kNFSd 8 of 9] nfsd4: store current->tgid instead of lockowner hash in fl_pid NeilBrown
2004-09-03 2:34 ` [PATCH kNFSd 9 of 9] Remove redundant initialization in nfsd4_lockt NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041007201856.GA30356@fieldses.org \
--to=bfields@fieldses.org \
--cc=akpm@osdl.org \
--cc=neilb@cse.unsw.edu.au \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.