From: Andrew Morton <akpm@osdl.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: piggin@cyberone.com.au, chrisw@osdl.org,
linux-kernel@vger.kernel.org, davej@codemonkey.org.uk
Subject: Re: kswapd in tight loop 2.6.9-rc3-bk-recent
Date: Thu, 7 Oct 2004 21:57:02 -0700 [thread overview]
Message-ID: <20041007215702.7a20ba27.akpm@osdl.org> (raw)
In-Reply-To: <41661C30.6070102@yahoo.com.au>
Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
> - if (zone->free_pages <= zone->pages_high) {
> + if (zone->free_pages < zone->pages_high) {
This is too subtle. An open-coded test for non-zero ->present_pages is far
more readable and maintainable.
next prev parent reply other threads:[~2004-10-08 4:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-07 21:20 kswapd in tight loop 2.6.9-rc3-bk-recent Chris Wright
2004-10-07 21:39 ` Dave Jones
2004-10-07 21:49 ` Chris Wright
2004-10-07 23:40 ` Andrew Morton
2004-10-08 0:34 ` Nick Piggin
2004-10-08 0:37 ` Andrew Morton
2004-10-08 0:51 ` Chris Wright
2004-10-08 1:40 ` Andrew Morton
2004-10-08 0:42 ` Andrew Morton
2004-10-08 1:41 ` Chris Wright
2004-10-08 1:51 ` Chris Wright
2004-10-08 1:53 ` Andrew Morton
2004-10-08 2:46 ` Nick Piggin
2004-10-08 3:01 ` Andrew Morton
2004-10-08 3:13 ` Nick Piggin
2004-10-08 3:30 ` Andrew Morton
2004-10-08 3:54 ` Nick Piggin
2004-10-08 4:48 ` Nick Piggin
2004-10-08 4:57 ` Andrew Morton [this message]
2004-10-08 5:21 ` Chris Wright
2004-10-08 5:27 ` Chris Wright
2004-10-08 10:10 ` Nick Piggin
2004-10-08 3:15 ` Nick Piggin
2004-10-08 3:05 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041007215702.7a20ba27.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=chrisw@osdl.org \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=piggin@cyberone.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.