All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Knorr <kraxel@bytesex.org>
To: Michael Geng <linux@MichaelGeng.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: video_usercopy() enforces change of VideoText IOCTLs since 2.6.8
Date: Mon, 11 Oct 2004 17:14:55 +0200	[thread overview]
Message-ID: <20041011151455.GC23632@bytesex> (raw)
In-Reply-To: <20041010085541.GA1642@t-online.de>

> +#define VTXIOCGETINFO	_IOR  (0x81,  1, vtx_info_t)
> +#define VTXIOCCLRPAGE	_IOW  (0x81,  2, vtx_pagereq_t)
> +#define VTXIOCCLRFOUND	_IOW  (0x81,  3, vtx_pagereq_t)
> +#define VTXIOCPAGEREQ	_IOW  (0x81,  4, vtx_pagereq_t)
> +#define VTXIOCGETSTAT	_IOW  (0x81,  5, vtx_pagereq_t)
> +#define VTXIOCGETPAGE	_IOW  (0x81,  6, vtx_pagereq_t)
> +#define VTXIOCSTOPDAU	_IOW  (0x81,  7, vtx_pagereq_t)

Hmm, _IOW for VTXIOCGET* looks bogous, is that really correct?

Note that you often need RW for read/get ioctls because even these
often pass data to the driver as well (for example the vtx page number
you want query the status for).  Please double-check that.  Otherwise
the patch looks ok to me.

  Gerd

-- 
return -ENOSIG;

  reply	other threads:[~2004-10-11 15:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-07 16:54 video_usercopy() enforces change of VideoText IOCTLs since 2.6.8 Michael Geng
2004-10-08 10:52 ` Gerd Knorr
2004-10-08 21:00   ` Andrew Morton
2004-10-09  9:28     ` Gerd Knorr
2004-10-09 11:28       ` Michael Geng
2004-10-09 12:18         ` Gerd Knorr
2004-10-10  8:55           ` Michael Geng
2004-10-11 15:14             ` Gerd Knorr [this message]
2004-10-11 16:21               ` Michael Geng
2004-10-13 11:00                 ` Alan Cox
2004-10-13 14:42                   ` Michael Geng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041011151455.GC23632@bytesex \
    --to=kraxel@bytesex.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@MichaelGeng.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.