All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: mike.miller@hp.com, Andrew Morton <akpm@osdl.org>,
	Linus Torvalds <torvalds@osdl.org>
Cc: iss_storagedev@hp.com, Cciss-discuss@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: [2.6 patch] fix block/cciss.c with PROC_FS=n
Date: Tue, 12 Oct 2004 20:43:46 +0200	[thread overview]
Message-ID: <20041012184346.GC18579@stusta.de> (raw)


I got the following compile error in both 2.6.9-rc4 and 2.6.9-rc4-mm1 
when compiling with CONFIG_PROC_FS=n:


<--  snip  -->

...
  LD      .tmp_vmlinux1
kernel/built-in.o(.text+0x1d42b): In function `crash_create_proc_entry':
: undefined reference to `proc_vmcore'
drivers/built-in.o(.text+0x234eb8): In function `cciss_init_one':
: undefined reference to `cciss_scsi_setup'
drivers/built-in.o(.text+0x235173): In function `cciss_remove_one':
: undefined reference to `cciss_unregister_scsi'
make: *** [.tmp_vmlinux1] Error 1

<--  snip  -->


The patch below fixes this issue.


I don't know whether this might qualify it for 2.6.9:
- it fixes the only CONFIG_PROC_FS=n compile error I found in 2.6.9-rc4
- it has obviously no effect in the CONFIG_PROC_FS=y case


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.9-rc4-mm1-full/drivers/block/cciss.c.old	2004-10-12 20:36:33.000000000 +0200
+++ linux-2.6.9-rc4-mm1-full/drivers/block/cciss.c	2004-10-12 20:37:16.000000000 +0200
@@ -185,10 +185,11 @@
         }
         return c;
 }
-#ifdef CONFIG_PROC_FS
 
 #include "cciss_scsi.c"		/* For SCSI tape support */
 
+#ifdef CONFIG_PROC_FS
+
 /*
  * Report information about this controller.
  */


             reply	other threads:[~2004-10-12 20:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-12 18:43 Adrian Bunk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-10-13 14:18 [2.6 patch] fix block/cciss.c with PROC_FS=n Miller, Mike (OS Dev)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041012184346.GC18579@stusta.de \
    --to=bunk@stusta.de \
    --cc=Cciss-discuss@lists.sourceforge.net \
    --cc=akpm@osdl.org \
    --cc=iss_storagedev@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.miller@hp.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.