From: Matt Mackall <mpm@selenic.com>
To: Con Kolivas <kernel@kolivas.org>
Cc: netdev@oss.sgi.com,
linux kernel mailing list <linux-kernel@vger.kernel.org>,
davem@redhat.com, Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH] netconsole support for b44
Date: Tue, 12 Oct 2004 16:57:32 -0500 [thread overview]
Message-ID: <20041012215732.GV31237@waste.org> (raw)
In-Reply-To: <416C5122.9040001@kolivas.org>
On Wed, Oct 13, 2004 at 07:48:18AM +1000, Con Kolivas wrote:
> Matt Mackall wrote:
> >On Tue, Oct 12, 2004 at 09:39:23PM +1000, Con Kolivas wrote:
> >
> >>This patch adds poll support to the b44 driver to allow netconsole
> >>support. Style lifted straight from 8139too.c
> >>
> >>here is the dmesg output with it in place:
> >>
> >>netconsole: device eth0 not up yet, forcing it
> >>netconsole: carrier detect appears flaky, waiting 10 seconds
> >>b44: eth0: Link is down.
> >>b44: eth0: Link is up at 100 Mbps, full duplex.
> >>b44: eth0: Flow control is on for TX and on for RX.
> >>netconsole: network logging started
> >>
> >>output confirmed by netcat on other system.
> >>
> >>Signed-off-by: Con Kolivas <kernel@kolivas.org>
> >
> >
> >+ disable_irq(dev->irq);
> >+ b44_interrupt (dev->irq, dev, NULL);
> >+ enable_irq(dev->irq);
> >
> >Aside from this bizarre whitespace convention and neglecting to cc:
> >me, looks good.
> >
>
> sorry,sorry,thanks.
>
> Can you explain where I went wrong in the whitespace so I don't make the
> same mistake again? It looked pretty standard to me.
Stray space between b44_interrupt and args.
> Should I nudge akpm with this or will it go via another route?
Jeff Garzik usually picks up net driver stuff, I think he got this one.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2004-10-12 21:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-12 11:39 [PATCH] netconsole support for b44 Con Kolivas
2004-10-12 18:09 ` Matt Mackall
2004-10-12 21:48 ` Con Kolivas
2004-10-12 21:57 ` Matt Mackall [this message]
2004-10-12 23:26 ` [PATCH]b44poll - whitespace Con Kolivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041012215732.GV31237@waste.org \
--to=mpm@selenic.com \
--cc=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.