From: viro@parcelfarce.linux.theplanet.co.uk
To: Alex Kiernan <alex.kiernan@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, viro@ZenII.linux.org.uk
Subject: Re: Submitting patches for unmaintained areas (Solaris x86 UFS bug)
Date: Wed, 13 Oct 2004 14:43:51 +0100 [thread overview]
Message-ID: <20041013134350.GA23987@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <c461c0d104101305103792ad7a@mail.gmail.com>
On Wed, Oct 13, 2004 at 01:10:10PM +0100, Alex Kiernan wrote:
> On Wed, 13 Oct 2004 12:06:29 +0100, Alex Kiernan <alex.kiernan@gmail.com> wrote:
> > I've run into a bug in the UFS reading code (on Solaris x86 the
> > major/minor numbers are in 2nd indirect offset not the first), so I've
> > patched it & bugzilled it
> > (http://bugzilla.kernel.org/show_bug.cgi?id=3475).
> >
> > But where do I go from here? There doesn't seem to be a maintainer for
> > UFS so I can't send it there.
> >
>
> After advice from Alan (thanks), here's the patch which addresses the
> problem I'm seeing. Specifically it appears that on x86 Solaris stores
> the major/minor device numbers in the 2nd indirect block, not the
> first.
1) please, move old_encode_dev()/old_decode_dev() into your helper functions.
2) we could do a bit better now that we have large dev_t. What are complete
rules for
a) Solaris userland dev_t => on-disk data
b) major/minor => Solaris userland dev_t
on sparc and x86 Solaris?
next prev parent reply other threads:[~2004-10-13 13:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-13 11:06 Submitting patches for unmaintained areas (Solaris x86 UFS bug) Alex Kiernan
2004-10-13 12:10 ` Alex Kiernan
2004-10-13 13:43 ` viro [this message]
2004-10-15 16:35 ` Alex Kiernan
2004-10-18 10:20 ` Alex Kiernan
2004-10-19 8:21 ` Alex Kiernan
2004-10-13 12:19 ` Haroldo Gamal
2004-10-13 15:05 ` Randy.Dunlap
2004-10-14 11:16 ` Haroldo Gamal
2004-10-14 15:15 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041013134350.GA23987@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=alex.kiernan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenII.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.