Re: [PATCH] NFS nolock broken in 2.6.9-rc4

[Olaf Kirch <okir@suse.de>]

On Fri, Oct 15, 2004 at 04:44:31PM +0200, Trond Myklebust wrote:
> NO! The correct way to do this is to handle it with a call to
> posix_lock_file() in the NFS code for the particular case of "nolock".

Urrrgh.. this looks complicated and duplicates code. Then I'd rather
have two struct file_operations, one for normal operations with a .lock
function, and a second one for nolock without.

> for details on why the changes were made (and that should make it
> obvious why your patch is wrong). The VFS must NOT be allowed to
> interfere if a filesystem has its own ->lock() method: that will violate
> the ability of filesystems to impose rigid locking rules.

My patch doesn't interfere; it just falls back to the original code if
the fs routine returns LOCK_USE_CLNT. In that respect, it doesn't
interfere with the new code.

Olaf
-- 
Olaf Kirch     | Things that make Monday morning interesting, #1:
okir@suse.de   |        "I want to use NFS over AX25, can you help me?"
---------------+ 


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs