On Fri, Oct 15, 2004 at 05:44:59PM +0200, Daniele Pizzoni wrote: > I ask, what rationale there is behind checking all printks to include > the "appropriate" constant? Should then we make printk fail when called > without KERN_ constant? Or can I force with a sed script all defaulted > printk to KERN_WARNING? No. Consider this.. printk (KERN_INFO "blah blah "); if (foo) printk ("%s", stringptr); else printk ("%d", number); printk ("\n"); There's nothing wrong with any of those printk's, so you cannot do the checks you mention above. Dave