All of lore.kernel.org
 help / color / mirror / Atom feed
From: Piotr Neuman <sikkh@wp.pl>
To: user-mode-linux-devel@lists.sourceforge.net
Subject: [uml-devel] [patch] open_meta_file (meta_fs.c) error reporting fix.
Date: Sat, 16 Oct 2004 18:35:02 +0200	[thread overview]
Message-ID: <200410161835.02592.sikkh@wp.pl> (raw)

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

Small bug in open_meta_file() prevents error reporting if memory allocation in 
get_path() fails (pretty unprobable but still).

Fix included (applies to UML ver. 2.6.8-um1 + externfs patch).

[-- Attachment #2: hostfs_open_meta_file.patch --]
[-- Type: text/x-diff, Size: 445 bytes --]

--- linux-uml/fs/hostfs/meta_fs.c.old	2004-10-16 18:32:17.514517144 +0200
+++ linux-uml/fs/hostfs/meta_fs.c	2004-10-16 18:25:14.000000000 +0200
@@ -83,8 +83,10 @@ static int open_meta_file(const char *pa
 		goto out;
 
 	meta_file = get_path(meta_path, meta_tmp, sizeof(meta_tmp));
-	if(meta_file == NULL)
+	if(meta_file == NULL) {
+		err = -ENOMEM;
 		goto out;
+	}
 	
 	err = open_filehandle(meta_file, of_rdwr(OPENFLAGS()), 0, fh);
 	if(err)

                 reply	other threads:[~2004-10-16 16:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200410161835.02592.sikkh@wp.pl \
    --to=sikkh@wp.pl \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.