From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Date: Sun, 17 Oct 2004 16:19:53 +0000 Subject: [KJ] Re: [PATCH 0/8] replacing/fixing printk with pr_debug/pr_info Message-Id: <20041017161953.GA24810@elte.hu> MIME-Version: 1 Content-Type: multipart/mixed; boundary="===============22273247455900957==" List-Id: References: <1098031764.3023.45.camel@pdp11.tsho.org> In-Reply-To: <1098031764.3023.45.camel@pdp11.tsho.org> To: Daniele Pizzoni Cc: kernel-janitors , LKML --===============22273247455900957== Content-Type: text/plain; charset=us-ascii Content-Disposition: inline * Daniele Pizzoni wrote: > Hello, I'm going to post a series of small janitorial patches focused on > 1) replacing DPRINTK-style macros with pr_debug from kernel.h > 2) replacing printk(KERN_INFO ...) with pr_info(...) > 3) fixing _obvious_ inconsistencies of printk levels as: > > printk(KERN_INFO "Start... "); > ... > printk("Ok!\n"); 1) be careful, there is no inconsistency here. It's a printk that doesnt end in a "\n" in the first line. 2) i dont like the pr_print name at all. What's wrong with Dprintk or dprintk? Just define them in kernel.h, this will also make your patch much smaller. Ingo --===============22273247455900957== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org http://lists.osdl.org/mailman/listinfo/kernel-janitors --===============22273247455900957==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269213AbUJQQ0w (ORCPT ); Sun, 17 Oct 2004 12:26:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269187AbUJQQWj (ORCPT ); Sun, 17 Oct 2004 12:22:39 -0400 Received: from mx1.elte.hu ([157.181.1.137]:22959 "EHLO mx1.elte.hu") by vger.kernel.org with ESMTP id S269221AbUJQQUY (ORCPT ); Sun, 17 Oct 2004 12:20:24 -0400 Date: Sun, 17 Oct 2004 18:19:53 +0200 From: Ingo Molnar To: Daniele Pizzoni Cc: kernel-janitors , LKML Subject: Re: [PATCH 0/8] replacing/fixing printk with pr_debug/pr_info in arch/i386 - intro Message-ID: <20041017161953.GA24810@elte.hu> References: <1098031764.3023.45.camel@pdp11.tsho.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1098031764.3023.45.camel@pdp11.tsho.org> User-Agent: Mutt/1.4.1i X-ELTE-SpamVersion: MailScanner 4.31.6-itk1 (ELTE 1.2) SpamAssassin 2.63 ClamAV 0.73 X-ELTE-VirusStatus: clean X-ELTE-SpamCheck: no X-ELTE-SpamCheck-Details: score=-4.9, required 5.9, autolearn=not spam, BAYES_00 -4.90 X-ELTE-SpamLevel: X-ELTE-SpamScore: -4 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Daniele Pizzoni wrote: > Hello, I'm going to post a series of small janitorial patches focused on > 1) replacing DPRINTK-style macros with pr_debug from kernel.h > 2) replacing printk(KERN_INFO ...) with pr_info(...) > 3) fixing _obvious_ inconsistencies of printk levels as: > > printk(KERN_INFO "Start... "); > ... > printk("Ok!\n"); 1) be careful, there is no inconsistency here. It's a printk that doesnt end in a "\n" in the first line. 2) i dont like the pr_print name at all. What's wrong with Dprintk or dprintk? Just define them in kernel.h, this will also make your patch much smaller. Ingo