From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-hotplug@vger.kernel.org
Subject: volume_id fix
Date: Mon, 18 Oct 2004 19:42:55 +0000 [thread overview]
Message-ID: <20041018194255.GA7819@vrfy.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 60 bytes --]
I've been told that open() should not pass O_NONBLOCK.
Kay
[-- Attachment #2: udev-volume_id-01.patch --]
[-- Type: text/plain, Size: 384 bytes --]
===== extras/volume_id/volume_id.c 1.7 vs edited =====
--- 1.7/extras/volume_id/volume_id.c 2004-10-06 00:36:16 +02:00
+++ edited/extras/volume_id/volume_id.c 2004-10-18 21:16:20 +02:00
@@ -2128,7 +2128,7 @@
struct volume_id *id;
int fd;
- fd = open(path, O_RDONLY | O_NONBLOCK);
+ fd = open(path, O_RDONLY);
if (fd < 0) {
dbg("unable to open '%s'", path);
return NULL;
next reply other threads:[~2004-10-18 19:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-18 19:42 Kay Sievers [this message]
2004-10-18 19:55 ` volume_id fix Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041018194255.GA7819@vrfy.org \
--to=kay.sievers@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.