Re: potential bug in "xm atropos" implementation

[Christian Limpach <Christian.Limpach@cl.cam.ac.uk>]

On Mon, Oct 18, 2004 at 03:21:38PM -0700, Diwaker Gupta wrote:
> From tools/libxc/xc_atropos.c:
> 
> int xc_atropos_domain_set(int xc_handle,
>                           u32 domid, u64 period, u64 slice, u64 latency,
>                           int xtratime)
> 
> which takes 6 arguments
> 
> From tools/python/xen/xm/main.py:
> class ProgAtropos(Prog):
> <snip>
>     def main(self, args):
>         if len(args) != 5: self.err("%s: Invalid argument(s)" % args[0])
>         dom = args[1]
>         v = map(int, args[2:5])
>         server.xend_domain_cpu_atropos_set(dom, *v)
> 
> Now if you specify all 6 arguments on the command line, xm atropos
> fails with "Invalid arguments" due to the above code. If you give 5
> arguments, ProgAtropos fails since the corresponding libxc function
> call takes 6 arguments.

No, the 6th argument you see in the xc_atropos_domain_set function
signature (i.e. the function's 1st argument -- xc_handle) is added
in the Pyhton<->xc interface function pyxc_atropos_domain_set
(in tools/python/xen/lowlevel/xc/xc.c).

    christian



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl