From: Christoph Hellwig <hch@infradead.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: mingo@elte.hu, Linux Kernel list <linux-kernel@vger.kernel.org>,
linuxppc64-dev <linuxppc64-dev@ozlabs.org>,
Linus Torvalds <torvalds@osdl.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] generic irq subsystem: ppc64 port
Date: Tue, 19 Oct 2004 09:41:32 +0100 [thread overview]
Message-ID: <20041019084131.GA7100@infradead.org> (raw)
In-Reply-To: <1098174500.11449.65.camel@gaston>
On Tue, Oct 19, 2004 at 06:28:20PM +1000, Benjamin Herrenschmidt wrote:
> Hi !
>
> That patch will unfortunately break a load of ppc64 boxes.
>
> If you look closely at the ppc64 code, you'll notice we don't
> use the irq_desc array directly but go through a get_irq_desc()
> accessor. This is because our interrupt numbers can be very
> large and scattered, and thus we have a remapping tree.
>
> I still like the idea of the patch, so it would be useful if
> you added the possibility for us to just change that behaviour,
> that is replace all occursences of irq_descs + i with get_irq_desc()
> and provide a generic one that just does that, with a #ifndef so
> that the architecture can provide it's own.
>
> If you agree with the principle, though, I suppose I can do it
> and send a proposed patch tomorrow.
The PPC64 changes were actually my fault. I think get_irq_desc() is okay.
next prev parent reply other threads:[~2004-10-19 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200410190714.i9J7Elnx027734@hera.kernel.org>
2004-10-19 8:28 ` [PATCH] generic irq subsystem: ppc64 port Benjamin Herrenschmidt
2004-10-19 8:41 ` Christoph Hellwig [this message]
2004-10-19 9:15 ` Ingo Molnar
2004-10-20 1:24 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041019084131.GA7100@infradead.org \
--to=hch@infradead.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.