From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 19 Oct 2004 11:13:07 +0200 From: Lars Marowsky-Bree To: drbd-dev@lists.linbit.com Message-ID: <20041019091307.GD9603@marowsky-bree.de> References: <20041019073224.518E93BE6D@garcon.linbit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20041019073224.518E93BE6D@garcon.linbit.com> Subject: [Drbd-dev] Re: [DRBD-cvs] r1598 - trunk/user List-Id: Coordination of development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2004-10-19T09:32:24, svn@svn.drbd.org wrote: > Author: phil > Date: 2004-10-19 09:32:21 +0200 (Tue, 19 Oct 2004) > New Revision: 1598 > > Modified: > trunk/user/Makefile > trunk/user/drbdmeta.c > Log: > [patch by LGE] > * removed the dependency on glib, and use the kernel's > includes instead. Do not do that. Please. Including kernel-headers from user-space is an absolute nightmare, it keeps breaking sporadically and in particular on non-i386 archs. The kernel headers just aren't meant to be used in user-space (and are documented to not be supported for this), and all the build issues I've had with OCFS, Lustre, ... have been caused by this. In particular these headers > +#include /* for the __cpu_to_le64 etc. functions */ > +#include /* for the hweight functions */ > +#include /* for the __u32/64 type defs */ _are known to break_ on ia64/ppc64/s390x. I'd be very grateful if you could avoid this. Sincerely, Lars Marowsky-Brée -- High Availability & Clustering SUSE Labs, Research and Development SUSE LINUX AG - A Novell company