From: Dmitry Torokhov <dtor_core@ameritech.net>
To: linux-kernel@vger.kernel.org
Cc: Rusty Russell <rusty@rustcorp.com.au>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Remove MODULE_PARM from arch/i386
Date: Wed, 20 Oct 2004 10:25:18 -0500 [thread overview]
Message-ID: <200410201025.18345.dtor_core@ameritech.net> (raw)
In-Reply-To: <1098259264.10571.147.camel@localhost.localdomain>
On Wednesday 20 October 2004 03:01 am, Rusty Russell wrote:
> Name: Remove MODULE_PARM from i386 arch
> Status: Compiled on 2.6-bk
> Depends: Module/MODULE_PARM-defconfig.patch.gz
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
> This patch removes MODULE_PARM for everything under arch/i386.
> Currently only APM.
>
> diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .3678-linux-2.6-bk/arch/i386/kernel/apm.c .3678-linux-2.6-bk.updated/arch/i386/kernel/apm.c
> --- .3678-linux-2.6-bk/arch/i386/kernel/apm.c 2004-10-19 14:33:50.000000000 +1000
> +++ .3678-linux-2.6-bk.updated/arch/i386/kernel/apm.c 2004-10-20 17:56:12.000000000 +1000
> @@ -2393,27 +2393,27 @@ module_exit(apm_exit);
> MODULE_AUTHOR("Stephen Rothwell");
> MODULE_DESCRIPTION("Advanced Power Management");
> MODULE_LICENSE("GPL");
> -MODULE_PARM(debug, "i");
> +module_param(debug, bool, 0644);
> MODULE_PARM_DESC(debug, "Enable debug mode");
> -MODULE_PARM(power_off, "i");
> +module_param(power_off, bool, 0444);
^^^^^
I am wondering if we need to waste kernel resources by creating sysfs
attributes for parameters that can not be changed at runtime (by user
or kernel)...
--
Dmitry
prev parent reply other threads:[~2004-10-20 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 8:01 [PATCH] Remove MODULE_PARM from arch/i386 Rusty Russell
2004-10-20 15:25 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410201025.18345.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.