All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: [patch] 2.6.9-rc4-mm1: compile error with BLK_DEV_IDEDMA=n
Date: Wed, 20 Oct 2004 14:09:30 +0200	[thread overview]
Message-ID: <20041020120930.GA14071@stusta.de> (raw)
In-Reply-To: <20041011032502.299dc88d.akpm@osdl.org>

On Mon, Oct 11, 2004 at 03:25:02AM -0700, Andrew Morton wrote:
>...
> All 741 patches
>...
> bk-ide-dev.patch
>...


This patch causes the following compile error with 
CONFIG_BLK_DEV_IDEDMA=n:


<--  snip  -->

...
  CC      drivers/ide/ide-lib.o
drivers/ide/ide-lib.c: In function `ide_use_dma':
drivers/ide/ide-lib.c:78: warning: implicit declaration of function `__ide_dma_bad_drive'
drivers/ide/ide-lib.c:96: warning: implicit declaration of function `__ide_dma_good_drive'
...
  LD      .tmp_vmlinux1
drivers/built-in.o(.text+0x26c4bf): In function `ide_use_dma':
: undefined reference to `__ide_dma_bad_drive'
drivers/built-in.o(.text+0x26c50c): In function `ide_use_dma':
: undefined reference to `__ide_dma_good_drive'
make: *** [.tmp_vmlinux1] Error 1

<--  snip  -->


The following patch fixes this problem:


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.9-rc4-mm1/include/linux/ide.h	2004-10-20 13:29:37.000000000 +0200
+++ linux-2.6.9-rc4-mm1-full/include/linux/ide.h	2004-10-20 13:26:54.000000000 +0200
@@ -1534,8 +1534,13 @@
 	hwif->hwif_data = data;
 }
 
+
 /* ide-lib.c */
+
+#ifdef CONFIG_BLK_DEV_IDEDMA
 int ide_use_dma(ide_drive_t *);
+#endif
+
 extern u8 ide_dma_speed(ide_drive_t *drive, u8 mode);
 extern u8 ide_rate_filter(u8 mode, u8 speed); 
 extern int ide_dma_enable(ide_drive_t *drive);
--- linux-2.6.9-rc4-mm1-full/drivers/ide/ide-lib.c.old	2004-10-20 02:02:13.000000000 +0200
+++ linux-2.6.9-rc4-mm1-full/drivers/ide/ide-lib.c	2004-10-20 13:26:20.000000000 +0200
@@ -69,6 +69,7 @@
 
 EXPORT_SYMBOL(ide_xfer_verbose);
 
+#ifdef CONFIG_BLK_DEV_IDEDMA
 int ide_use_dma(ide_drive_t *drive)
 {
 	struct hd_driveid *id = drive->id;
@@ -100,6 +101,7 @@
 }
 
 EXPORT_SYMBOL_GPL(ide_use_dma);
+#endif /* CONFIG_BLK_DEV_IDEDMA */
 
 /**
  *	ide_dma_speed	-	compute DMA speed



  parent reply	other threads:[~2004-10-20 12:16 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-11 10:25 2.6.9-rc4-mm1 Andrew Morton
2004-10-11 11:29 ` 2.6.9-rc4-mm1 Eyal Lebedinsky
2004-10-11 11:37 ` 2.6.9-rc4-mm1 Tim Cambrant
2004-10-11 11:38 ` 2.6.9-rc4-mm1 Nick Piggin
2004-10-11 19:13   ` 2.6.9-rc4-mm1 Andrew Morton
2004-10-11 22:57     ` 2.6.9-rc4-mm1 Nick Piggin
2004-10-11 11:43 ` 2.6.9-rc4-mm1 Brice Goglin
2004-10-11 12:30 ` 2.6.9-rc4-mm1 Con Kolivas
2004-10-11 13:17   ` 2.6.9-rc4-mm1 Alan Cox
2004-10-11 14:23     ` 2.6.9-rc4-mm1 Con Kolivas
2004-10-11 14:30     ` 2.6.9-rc4-mm1 J.A. Magallon
2004-10-11 12:44 ` Unable to handle kernel paging request at virtual address 0000ed9c [was Re: 2.6.9-rc4-mm1] Ramón Rey Vicente
2004-10-11 13:19   ` Tim Cambrant
2004-10-11 13:34     ` Ramón Rey Vicente
2004-10-11 13:43 ` 2.6.9-rc4-mm1 Jack Byer
2004-10-11 21:58   ` 2.6.9-rc4-mm1 Andrew Morton
2004-10-11 22:10     ` 2.6.9-rc4-mm1 Tom Rini
2004-10-11 23:14     ` 2.6.9-rc4-mm1 Thayne Harbaugh
2004-10-12  0:32     ` 2.6.9-rc4-mm1 Jack Byer
2004-10-11 14:22 ` 2.6.9-rc4-mm1 J.A. Magallon
2004-10-11 14:23 ` 2.6.9-rc4-mm1 Eyal Lebedinsky
2004-10-11 15:33 ` 2.6.9-rc4-mm1 [missing i2o patch in the main patch] syrius.ml
2004-10-11 15:47 ` 2.6.9-rc4-mm1 Zwane Mwaikambo
2004-10-11 15:49   ` 2.6.9-rc4-mm1 Andi Kleen
2004-10-11 15:58     ` 2.6.9-rc4-mm1 Zwane Mwaikambo
2004-10-11 16:01       ` 2.6.9-rc4-mm1 Andi Kleen
2004-10-11 19:55   ` 2.6.9-rc4-mm1 Andrew Morton
2004-10-11 21:52     ` 2.6.9-rc4-mm1 Andi Kleen
2004-10-12 14:24     ` 2.6.9-rc4-mm1 Zwane Mwaikambo
2004-10-11 16:08 ` 2.6.9-rc4-mm1 Jeff Garzik
2004-10-11 22:38   ` 2.6.9-rc4-mm1 Lee Revell
2004-10-11 17:57 ` 2.6.9-rc4-mm1 (compile stats) John Cherry
2004-10-11 18:51 ` 2.6.9-rc4-mm1 Brice Goglin
2004-10-11 20:18   ` 2.6.9-rc4-mm1 Adrian Bunk
2004-10-11 20:15 ` [patch] 2.6.9-rc4-mm1: ALSA compile error with KMOD=n Adrian Bunk
2004-10-11 20:15 ` Adrian Bunk
2004-10-12 14:25 ` [patch] 2.6.9-rc4-mm1: USB compile error with PROC_FS=n Adrian Bunk
2004-10-12 16:34   ` Greg KH
2004-10-12 16:36     ` Greg KH
2004-10-12 18:49 ` 2.6.9-rc4-mm1: CRASH_DUMP " Adrian Bunk
2004-10-13 14:30   ` Hariprasad Nellitheertha
2004-10-13  7:42 ` 2.6.9-rc4-mm1 Wen-chien Jesse Sung
2004-10-13  8:16   ` 2.6.9-rc4-mm1 Hideo AOKI
2004-10-13 13:07 ` 2.6.9-rc4-mm1 Jesse Stockall
2004-10-13 13:19   ` 2.6.9-rc4-mm1 Mathieu Segaud
2004-10-13 13:34     ` 2.6.9-rc4-mm1 Jesse Stockall
2004-10-13 17:27     ` 2.6.9-rc4-mm1 Peter Adebahr
2004-10-14  4:42 ` 2.6.9-rc4-mm1 Hiroyuki KAMEZAWA
2004-10-14  4:50   ` 2.6.9-rc4-mm1 Andrew Morton
2004-10-14  5:23     ` 2.6.9-rc4-mm1 Hiroyuki KAMEZAWA
2004-10-14 17:50     ` 2.6.9-rc4-mm1 Christian Borntraeger
2004-10-15  7:08       ` 2.6.9-rc4-mm1 J.A. Magallon
2004-10-15 16:47         ` 2.6.9-rc4-mm1 Lee Revell
2004-10-17 16:15 ` 2.6.9-rc4-mm1: initramfs build fix Martin Waitz
2004-10-17 17:29   ` 2.6.9-rc4-mm1: initramfs build fix [u] Martin Schlemmer [c]
2004-10-17 21:33     ` Sam Ravnborg
2004-10-17 20:12       ` Martin Schlemmer [c]
2004-10-18 19:26         ` Martin Schlemmer [c]
2004-10-20 12:09 ` Adrian Bunk [this message]
2004-10-20 14:08   ` [patch] 2.6.9-rc4-mm1: compile error with BLK_DEV_IDEDMA=n Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041020120930.GA14071@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=bzolnier@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.