All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: tglx@linutronix.de, Andrew Morton <akpm@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sunrpc: replace sleep_on_timeout()
Date: Thu, 21 Oct 2004 09:42:45 +0200	[thread overview]
Message-ID: <20041021074245.GB20573@elte.hu> (raw)
In-Reply-To: <1098343597.28394.10.camel@lade.trondhjem.org>


* Trond Myklebust <trond.myklebust@fys.uio.no> wrote:

> > -		sleep_on_timeout(&destroy_wait, 1*HZ);
> > +		wait_event_timeout(destroy_wait,
> > +			atomic_read(&clnt->cl_users) > 0, 1*HZ);
> >  	}
> >  
> 
> No. The above is incorrect, and has the potential for a pretty
> catastrophic hang due to the enclosing loop. Please replace with
> 
> 	wait_event_timeout(destroy_wait, atomic_read(&clnt->cl_users) == 0,
> 1*HZ);

ah, indeed. Do you in principle agree with these sleep_on() =>
wait_event*() conversions in the NFS code? (as long as they are
correct). sleep_on() is really becoming an architectural wart these
days.

	Ingo

  reply	other threads:[~2004-10-21  7:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-20 19:21 [PATCH] sunrpc: replace sleep_on_timeout() Thomas Gleixner
2004-10-21  7:26 ` Trond Myklebust
2004-10-21  7:42   ` Ingo Molnar [this message]
2004-10-21  8:24     ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041021074245.GB20573@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.