From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: Am I paranoid or is everyone out to break my kernel builds (Breakage in drivers/pcmcia)
Date: Thu, 21 Oct 2004 10:50:27 +0100 [thread overview]
Message-ID: <20041021105026.C3089@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20041021023135.074c7988.akpm@osdl.org>; from akpm@osdl.org on Thu, Oct 21, 2004 at 02:31:35AM -0700
On Thu, Oct 21, 2004 at 02:31:35AM -0700, Andrew Morton wrote:
> Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> > Take special note of the '&' before 'num' in the above initialiser, and
> > check the structure:
>
> Something's out of whack with your tree. You should have:
Ok, but what's the point of the change? If it's to indicate that
we're returning a value, shouldn't the other module_param* macros
also be fixed in the same way, or do we just like special cases?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-10-21 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 9:09 Am I paranoid or is everyone out to break my kernel builds (Breakage in drivers/pcmcia) Russell King
2004-10-21 9:31 ` Andrew Morton
2004-10-21 9:50 ` Russell King [this message]
2004-10-21 17:02 ` Andrew Morton
2004-10-21 23:46 ` Rusty Russell
2004-10-21 9:40 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041021105026.C3089@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.