From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linus Torvalds <torvalds@osdl.org>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] qla1820 iomem annotations
Date: Thu, 21 Oct 2004 18:30:57 +0100 [thread overview]
Message-ID: <20041021173057.GC24336@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20041021172547.GA8242@infradead.org>
On Thu, Oct 21, 2004 at 06:25:47PM +0100, Christoph Hellwig wrote:
> On Thu, Oct 21, 2004 at 04:14:06PM +0100, Al Viro wrote:
> > On Thu, Oct 21, 2004 at 10:00:32AM +0100, Christoph Hellwig wrote:
> > > This breaks old-style PIO support in this driver which is required for the
> > > Visual Workstations.
> >
> > Where? __iomem is #defined to nothing for gcc. So that leaves only
> > the chunk below as theoretically possible source of changes, right?
>
> Sorry, this was totlly misworked. What I actually meant is that it gives
> the sparse warnings again in the PIO-config, so you trade sparse warnings
> for one variant vs ones for another variant.
Huh? We _already_ have these guys as pointers; so PIO variants were not
any happier with non-iomem ones.
Details, please...
prev parent reply other threads:[~2004-10-21 17:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 23:58 [PATCH] qla1820 iomem annotations viro
2004-10-21 9:00 ` Christoph Hellwig
2004-10-21 14:24 ` Linus Torvalds
2004-10-21 15:14 ` Al Viro
2004-10-21 17:25 ` Christoph Hellwig
2004-10-21 17:30 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041021173057.GC24336@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.