From: Jens Axboe <axboe@suse.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.6.9-ac3
Date: Fri, 22 Oct 2004 08:36:06 +0200 [thread overview]
Message-ID: <20041022063606.GB1820@suse.de> (raw)
In-Reply-To: <1098400086.18025.0.camel@localhost.localdomain>
On Fri, Oct 22 2004, Alan Cox wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/alan/linux-2.6/2.6.9/
If you're collection ide patchlets for later inclusion, please include
this as well. It makes sure we remove the ideX directory in proc when an
interface is removed. With ide-cs and repeated insert/reject cycles, we
end up with tons of ide2 entries.
Signed-off-by: Jens Axboe <axboe@suse.de>
--- /opt/kernel/linux-2.6/include/linux/ide.h 2004-10-11 12:19:40.000000000 +0200
+++ linux-2.6.9/include/linux/ide.h 2004-10-20 17:25:05.000000000 +0200
@@ -1063,6 +1063,7 @@
extern void proc_ide_create(void);
extern void proc_ide_destroy(void);
extern void destroy_proc_ide_drives(ide_hwif_t *);
+extern void destroy_proc_ide_interfaces(void);
extern void create_proc_ide_interfaces(void);
extern void ide_add_proc_entries(struct proc_dir_entry *, ide_proc_entry_t *, void *);
extern void ide_remove_proc_entries(struct proc_dir_entry *, ide_proc_entry_t *);
--- /opt/kernel/linux-2.6/drivers/ide/ide.c 2004-10-11 12:19:29.000000000 +0200
+++ linux-2.6.9/drivers/ide/ide.c 2004-10-20 17:25:54.000000000 +0200
@@ -798,6 +798,7 @@
#ifdef CONFIG_PROC_FS
destroy_proc_ide_drives(hwif);
+ destroy_proc_ide_interfaces();
#endif
hwgroup = hwif->hwgroup;
--- /opt/kernel/linux-2.6/drivers/ide/ide-proc.c 2004-10-11 12:19:29.000000000 +0200
+++ linux-2.6.9/drivers/ide/ide-proc.c 2004-10-20 17:31:02.040529272 +0200
@@ -731,10 +731,9 @@
for (h = 0; h < MAX_HWIFS; h++) {
ide_hwif_t *hwif = &ide_hwifs[h];
int exist = (hwif->proc != NULL);
-#if 0
- if (!hwif->present)
+
+ if (hwif->present)
continue;
-#endif
if (exist) {
destroy_proc_ide_drives(hwif);
ide_remove_proc_entries(hwif->proc, hwif_entries);
--
Jens Axboe
next prev parent reply other threads:[~2004-10-22 6:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 23:08 Linux 2.6.9-ac3 Alan Cox
2004-10-22 0:59 ` Mark Lord
2004-10-22 1:42 ` [patch 2.6.9-ac3] ide: fixes for 2.6.9-ac3 ide issues Mark Lord
2004-10-22 1:18 ` Linux 2.6.9-ac3 Con Kolivas
2004-10-22 1:50 ` [PATCH 2.6.9-ac3] delkin_cb: new driver for Cardbus IDE CF Adapter Mark Lord
2004-10-22 6:36 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-10-22 8:13 Linux 2.6.9-ac3 Luca Risolia
2004-10-22 9:21 ` Luc Saillard
2004-10-22 12:30 ` Luca Risolia
2004-10-22 12:34 ` Xavier Bestel
2004-10-22 13:33 ` Luc Saillard
2004-10-22 14:22 ` Ronald S. Bultje
2004-10-22 14:38 ` David Weinehall
2004-10-22 14:15 ` Gergely Nagy
2004-10-22 13:16 ` Luc Saillard
2004-10-22 14:07 ` Luca Risolia
2004-10-22 14:10 ` Gerd Knorr
2004-10-22 15:51 ` Alan Cox
2004-10-22 18:14 ` Gerd Knorr
2004-10-23 13:41 ` Luca Risolia
2004-10-22 11:09 ` Alan Cox
2004-10-22 13:00 ` Luca Risolia
2004-10-22 15:49 ` Alan Cox
2004-10-23 14:54 ` Bill Davidsen
2004-10-23 17:36 ` Luca Risolia
2004-10-25 22:22 ` Bill Davidsen
2004-10-26 5:29 ` Luc Saillard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041022063606.GB1820@suse.de \
--to=axboe@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.