From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC] platform_get_irq() return for no IRQ
Date: Fri, 22 Oct 2004 13:25:30 +0100 [thread overview]
Message-ID: <20041022132530.A3459@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20041022101018.GA17957@home.fluff.org>; from ben-linux@fluff.org on Fri, Oct 22, 2004 at 11:10:18AM +0100
On Fri, Oct 22, 2004 at 11:10:18AM +0100, Ben Dooks wrote:
> On Wed, Oct 20, 2004 at 06:40:15PM +0100, Ben Dooks wrote:
> > in drivers/base/platform.c, platform_get_irq() returns 0 if
> > there is no IRQ found in the resources, however 0 is a valid
> > IRQ on at least some of the ARM architectures.
> >
> > This patch changes the return code to be -ENOENT instead.
> >
> > Signed-of-by: Ben Dooks <ben-linux@fluff.org>
> >
>
> I should have also pointed out that as few things are
> actually using this at the moment, it would be a good
> idea to get this changed as soon as possible.
A better solution would be to make it return NO_IRQ. There's been some
discussions recently about having this implemented across all platforms,
and that's what stopped me submitting the version which used this macro
back when this was merged. (the fact that NO_IRQ is not defined by
everyone)
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
prev parent reply other threads:[~2004-10-22 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 17:40 [PATCH/RFC] platform_get_irq() return for no IRQ Ben Dooks
2004-10-22 10:10 ` Ben Dooks
2004-10-22 12:25 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041022132530.A3459@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=ben-linux@fluff.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.